Re: [PATCH 1/1] Grow: Report when grow needs metadata update

[NeilBrown <neilb@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 919 bytes --]

On Fri, 29 Aug 2014 20:47:12 +0000 Andy Smith <andy@strugglers.net> wrote:

> Report when the array's metadata needs updating instead of just
> reporting the generic "kernel too old" message.
> 
> Signed-off-by: Andy Smith <andy@strugglers.net>
> ---
>  Grow.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Grow.c b/Grow.c
> index a9c8589..76bb35a 100644
> --- a/Grow.c
> +++ b/Grow.c
> @@ -2255,7 +2255,9 @@ static int set_new_data_offset(struct mdinfo *sra, struct supertype *st,
>  		if (info2.space_before == 0 &&
>  		    info2.space_after == 0) {
>  			/* Metadata doesn't support data_offset changes */
> -			return 1;
> +			pr_err("%s: Metadata version doesn't support"
> +			       " data_offset changes\n", devname);
> +			goto release;
>  		}
>  		if (before > info2.space_before)
>  			before = info2.space_before;

Applied, thanks.

NeilBrown

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]