Re: [PATCH 00/12] Enabling WL8 R8.4 on dora

[Denys Dmytriyenko <denys@ti.com>]

On Wed, Sep 03, 2014 at 02:41:08PM +0000, Cooper Jr., Franklin wrote:
> 
> 
> > -----Original Message-----
> > From: R, Karthik
> > Sent: Wednesday, September 03, 2014 7:46 AM
> > To: Cooper Jr., Franklin; meta-arago@arago-project.org
> > Subject: RE: [meta-arago] [PATCH 00/12] Enabling WL8 R8.4 on dora
> > 
> > Hi Franklin,
> > 
> > Thanks for your inputs. I did some reading about these suggestions and I fully
> > understand your intent behind it.
> > I have regenerated the patches sent out the version 2 of this patch set for
> > review. Please review them if you find it in order.
> > If you need more details about the patches do let me know.
> > 
> > I read a note in the git help that said that the patches generated by using the
> > options that make the differences minimal like the -D option will result in
> > patches that cannot be applied by git am.

> [Franklin] -M not -D correct? Anyway I've never had an issue when I can't 
> apply patches when people use those options. I never had Denys complained 
> and he even frequently request that myself and other people use those 
> options I mentioned. I don't know if he does a bit more work behind the 
> scenes to get those patches to work but I've never ran into any problems.



 -M[<n>], --find-renames[=<n>]
     Detect renames. If n is specified, it is a threshold on the similarity index
     (i.e. amount of addition/deletions compared to the file’s size). For example,
     -M90% means Git should consider a delete/add pair to be a rename if more than 90%
     of the file hasn’t changed. Without a % sign, the number is to be read as a
     fraction, with a decimal point before it. I.e., -M5 becomes 0.5, and is thus the
     same as -M50%. Similarly, -M05 is the same as -M5%. To limit detection to exact
     renames, use -M100%. The default similarity index is 50%.

 -C[<n>], --find-copies[=<n>]
     Detect copies as well as renames. See also --find-copies-harder. If n is
     specified, it has the same meaning as for -M<n>.

 --find-copies-harder
     For performance reasons, by default, -C option finds copies only if the original
     file of the copy was modified in the same changeset. This flag makes the command
     inspect unmodified files as candidates for the source of copy. This is a very
     expensive operation for large projects, so use it with caution. Giving more than
     one -C option has the same effect.




> > So from a review point its fine, but I don't understand how it will get merged
> > into the repo?
> > Could you please help me understand the flow of the patches?
> > 
> > Regards
> > Karthik
> > 
> > -----Original Message-----
> > From: Cooper Jr., Franklin
> > Sent: Wednesday, September 03, 2014 3:17 AM
> > To: R, Karthik; meta-arago@arago-project.org
> > Subject: RE: [meta-arago] [PATCH 00/12] Enabling WL8 R8.4 on dora
> > 
> > If you can resend using --find-copies-harder it will make it a lot easier to
> > review. You might also need to play with the -M option to make sure your
> > only sending as little deltas as possible.
> > 
> > Also it would be nice in each of the patches if you add [for dora] to the patch
> > subject. I know you indicated that in the cover letter but it just makes things
> > easier and a good habit in case you don't always send cover letters.
> > 
> > I always use git send-email --annotate and manually add things like that to
> > each patch before I send it. A bit of a hassle for the sender but makes the
> > reviewer's life easier :)
> > 
> > > -----Original Message-----
> > > From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
> > > bounces@arago-project.org] On Behalf Of R, Karthik
> > > Sent: Tuesday, September 02, 2014 5:55 AM
> > > To: meta-arago@arago-project.org
> > > Subject: [meta-arago] [PATCH 00/12] Enabling WL8 R8.4 on dora
> > >
> > > This patch set contains the set of patches that are required to get
> > > the latest Wilink firmware on the dora branch.
> > > Most of the patches here are cherry picked from the master branch. A
> > > few of them needed minor rework.
> > >
> > > Note that this has been tested on the GLSDK 6.10 release line for
> > > dra7xx-evm as the target.
> > >
> > > Denys Dmytriyenko (4):
> > >   wl18xx-firmware: specify the branch being used for this version
> > >   hostap-daemon: specify the branch being used for this version
> > >   wpa-supplicant: specify the branch being used for this version
> > >   recipes-connectivity: remove remaining unnecessary exec permissions
> > >
> > > Yaniv Machani (8):
> > >   wpa-supplicant-wl18xx: Update recipe to ol_r8.a9.14 version.
> > >   hostap-daemon-wl18xx: Update recipe to ol_r8.a9.14 version
> > >   wl18xx : update to ol_r8.a9.14
> > >   Wl18xx : recipes update - tag changed to ol_r8.a9.14
> > >   wl18xx-target-scripts : Add new WiFi related scripts
> > >   wl18xx-compat: version update
> > >   wl18xx-wlconf: version update
> > >   wpa-supplicant-wl18xx: configuration files update
> > >
> > >  ...synchronization-between-bluetoothd-and-dr.patch |   0
> > >  .../0001-obexd-make-OPP-push-timeout-longer.patch  |   0
> > >  .../packagegroup-arago-tisdk-connectivity.bb       |   4 +-
> > >  .../ti-compat-wireless-wl18xx_r8.a8.10.bb          |  61 ---
> > >  .../ti-compat-wireless-wl18xx_r8.a9.14.bb          |  51 ++
> > >  .../wl18xx-firmware/wl18xx-firmware_r8.a8.10.bb    |  30 --
> > >  .../wl18xx-firmware/wl18xx-firmware_r8.a9.14.bb    |  31 ++
> > >  .../hostap/hostap-daemon-wl18xx_r8.a8.10.bb        |  23 -
> > >  .../hostap/hostap-daemon-wl18xx_r8.a9.14.bb        |  24 +
> > >  .../hostap/hostap-daemon/defconfig                 |   2 +-
> > >  .../recipes-connectivity/hostap/hostap.inc         |   7 +-
> > >  .../wl18xx-target-scripts_r8.a9.14.bb              |  25 +
> > >  .../recipes-connectivity/wlconf/wlconf_r8.a8.10.bb |  41 --
> > > .../recipes- connectivity/wlconf/wlconf_r8.a9.14.bb |  42 ++
> > > .../wpa-supplicant/wpa- supplicant-wl18xx/defconfig | 506 -------------------
> > >  .../wpa-supplicant-wl18xx_r8.a8.10.bb              |  24 -
> > >  .../wpa-supplicant-wl18xx_r8.a9.14.bb              |  25 +
> > >  .../wpa-supplicant/wpa-supplicant.inc              |  91 ++--
> > >  .../wpa-supplicant/wpa-supplicant/defaults-sane    |   8 -
> > >  .../wpa-supplicant/wpa-supplicant/defconfig        | 543
> > > +++++++++++++++++++++
> > >  .../fi.epitest.hostap.WPASupplicant.service        |   4 -
> > >  .../wpa-supplicant/fi.w1.wpa_supplicant1.service   |   4 -
> > >  .../wpa-supplicant/p2p_supplicant.conf             |   3 +-
> > >  .../wpa-supplicant/wpa_supplicant.conf             |   3 +-
> > >  .../ti-wifi-utils/ti-wifi-utils-wl18xx_r8.a8.10.bb |  31 --
> > > .../ti-wifi-utils/ti-wifi- utils-wl18xx_r8.a9.14.bb |  31 ++
> > >  26 files changed, 814 insertions(+), 800 deletions(-)  mode change
> > > 100755 =>
> > > 100644 meta-arago-distro/recipes-connectivity/bluez/bluez4/bluez4-fix-
> > > synchronization-between-bluetoothd-and-dr.patch
> > >  mode change 100755 => 100644 meta-arago-distro/recipes-
> > > connectivity/obexd/obexd-0.34/0001-obexd-make-OPP-push-timeout-
> > > longer.patch
> > >  mode change 100644 => 100755 meta-arago-distro/recipes-
> > > core/packagegroups/packagegroup-arago-tisdk-connectivity.bb
> > >  delete mode 100644
> > > meta-arago-extras/recipes-bsp/ti-compat-wireless/ti-
> > > compat-wireless-wl18xx_r8.a8.10.bb
> > >  create mode 100644
> > > meta-arago-extras/recipes-bsp/ti-compat-wireless/ti-
> > > compat-wireless-wl18xx_r8.a9.14.bb
> > >  delete mode 100644 meta-arago-extras/recipes-bsp/wl18xx-
> > > firmware/wl18xx-firmware_r8.a8.10.bb
> > >  create mode 100644 meta-arago-extras/recipes-bsp/wl18xx-
> > > firmware/wl18xx-firmware_r8.a9.14.bb
> > >  delete mode 100644 meta-arago-extras/recipes-
> > > connectivity/hostap/hostap-daemon-wl18xx_r8.a8.10.bb
> > >  create mode 100644 meta-arago-extras/recipes-
> > > connectivity/hostap/hostap-daemon-wl18xx_r8.a9.14.bb
> > >  create mode 100644 meta-arago-extras/recipes-connectivity/wl18xx-
> > > target-scripts/wl18xx-target-scripts_r8.a9.14.bb
> > >  delete mode 100644 meta-arago-extras/recipes-
> > > connectivity/wlconf/wlconf_r8.a8.10.bb
> > >  create mode 100644 meta-arago-extras/recipes-
> > > connectivity/wlconf/wlconf_r8.a9.14.bb
> > >  delete mode 100755 meta-arago-extras/recipes-connectivity/wpa-
> > > supplicant/wpa-supplicant-wl18xx/defconfig
> > >  delete mode 100644 meta-arago-extras/recipes-connectivity/wpa-
> > > supplicant/wpa-supplicant-wl18xx_r8.a8.10.bb
> > >  create mode 100644 meta-arago-extras/recipes-connectivity/wpa-
> > > supplicant/wpa-supplicant-wl18xx_r8.a9.14.bb
> > >  delete mode 100644 meta-arago-extras/recipes-connectivity/wpa-
> > > supplicant/wpa-supplicant/defaults-sane
> > >  create mode 100755 meta-arago-extras/recipes-connectivity/wpa-
> > > supplicant/wpa-supplicant/defconfig
> > >  delete mode 100644 meta-arago-extras/recipes-connectivity/wpa-
> > > supplicant/wpa-supplicant/fi.epitest.hostap.WPASupplicant.service
> > >  delete mode 100644 meta-arago-extras/recipes-connectivity/wpa-
> > > supplicant/wpa-supplicant/fi.w1.wpa_supplicant1.service
> > >  delete mode 100644
> > > meta-arago-extras/recipes-devtools/ti-wifi-utils/ti-
> > > wifi-utils-wl18xx_r8.a8.10.bb
> > >  create mode 100644
> > > meta-arago-extras/recipes-devtools/ti-wifi-utils/ti-
> > > wifi-utils-wl18xx_r8.a9.14.bb
> > >
> > > --
> > > 2.0.1
> > >
> > > _______________________________________________
> > > meta-arago mailing list
> > > meta-arago@arago-project.org
> > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago