From: Jan Kara <jack@suse.cz>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH 1/3] ext4: pass allocation_request struct to ext4_(alloc,splice)_branch
Date: Wed, 3 Sep 2014 18:25:52 +0200 [thread overview]
Message-ID: <20140903162552.GD17066@quack.suse.cz> (raw)
In-Reply-To: <1409695549-18605-2-git-send-email-tytso@mit.edu>
On Tue 02-09-14 18:05:47, Ted Tso wrote:
> Instead of initializing the allocation_request structure in
> ext4_alloc_branch(), set it up in ext4_ind_map_blocks(), and then pass
> it to ext4_alloc_branch() and ext4_splice_branch().
>
> This allows ext4_ind_map_blocks to pass flags in the allocation
> request structure without having to add Yet Another argument to
> ext4_alloc_branch().
The patch looks good. You can add:
Reviewed-by: Jan Kara <jack@suse.cz>
BTW:
> - goal = new_blocks[i] = ext4_new_meta_blocks(handle, inode,
> - goal, 0, NULL, &err);
> + ar->goal = new_blocks[i] = ext4_new_meta_blocks(handle,
> + ar->inode, ar->goal, 0, NULL, &err);
This seems to suggest ext4_new_meta_blocks() would be better off by
taking allocation_request argument as well?
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2014-09-03 16:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 22:05 [PATCH 0/3] Clean up the EXT4_STATE_DELALLOC_RESERVED state flag Theodore Ts'o
2014-09-02 22:05 ` [PATCH 1/3] ext4: pass allocation_request struct to ext4_(alloc,splice)_branch Theodore Ts'o
2014-09-03 16:25 ` Jan Kara [this message]
2014-09-03 17:17 ` Theodore Ts'o
2014-09-02 22:05 ` [PATCH 2/3] ext4: prepare to drop EXT4_STATE_DELALLOC_RESERVED Theodore Ts'o
2014-09-03 16:26 ` Jan Kara
2014-09-02 22:05 ` [PATCH 3/3] ext4: drop the EXT4_STATE_DELALLOC_RESERVED flag Theodore Ts'o
2014-09-03 16:26 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140903162552.GD17066@quack.suse.cz \
--to=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.