From: Frans Klaver <frans.klaver@xsens.com>
To: Johan Hovold <johan@kernel.org>
Cc: Frans Klaver <fransklaver@gmail.com>, <linux-usb@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH resend 2/2] usb: serial: xsens_mt: always bind to interface number 1
Date: Thu, 4 Sep 2014 11:05:47 +0200 [thread overview]
Message-ID: <20140904090546.GA6213@ci00147.test> (raw)
In-Reply-To: <20140904081522.GD4894@localhost>
On Thu, Sep 04, 2014 at 10:15:22AM +0200, Johan Hovold wrote:
> On Thu, Sep 04, 2014 at 09:12:05AM +0200, Frans Klaver wrote:
>
> > > static int xsens_mt_probe(struct usb_serial *serial,
> > > const struct usb_device_id *id)
> > > {
> > > - if (!has_required_endpoints(serial->interface->cur_altsetting))
> > > - return -ENODEV;
> > > - return 0;
> > > + if (serial->interface->cur_altsetting.desc.bInterfaceNumber == 1)
> >
> > This should be
> >
> > if (serial->interface->cur_altsetting->desc.bInterfaceNumber == 1)
>
> So this wasn't even compile tested. Always test your patches before
> submission, including trivial ones.
>
> Is the new version tested on actual hardware?
The implementation was tested (also fixed) before the first submission.
Not the patches. Looks like I've got a step to add.
The new version is applied, built and tested with some actual hardware
on 3.17-rc3.
Frans
next prev parent reply other threads:[~2014-09-04 9:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-01 9:39 [PATCH resend 1/2] usb: serial: xsens_mt: add author and description Frans Klaver
2014-09-01 9:39 ` [PATCH resend 2/2] usb: serial: xsens_mt: always bind to interface number 1 Frans Klaver
2014-09-04 7:12 ` Frans Klaver
2014-09-04 7:25 ` [PATCH " Frans Klaver
2014-09-04 8:15 ` [PATCH resend " Johan Hovold
2014-09-04 9:05 ` Frans Klaver [this message]
2014-09-04 9:22 ` Johan Hovold
2014-09-04 9:26 ` Frans Klaver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140904090546.GA6213@ci00147.test \
--to=frans.klaver@xsens.com \
--cc=fransklaver@gmail.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.