From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 57/89] drm/i915: Rewrite ABS_DIFF() in a
 safer manner
Date: Thu, 4 Sep 2014 15:11:44 +0200
Message-ID: <20140904131144.GM15520@phenom.ffwll.local>
References: <1409830075-11139-1-git-send-email-damien.lespiau@intel.com>
 <1409830075-11139-58-git-send-email-damien.lespiau@intel.com>
 <874mwnfuvn.fsf@intel.com>
 <20140904123224.GC25664@strange.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com
 [209.85.212.175])
 by gabe.freedesktop.org (Postfix) with ESMTP id 15A1E6E60F
 for <intel-gfx@lists.freedesktop.org>; Thu,  4 Sep 2014 06:11:24 -0700 (PDT)
Received: by mail-wi0-f175.google.com with SMTP id ho1so1055915wib.2
 for <intel-gfx@lists.freedesktop.org>; Thu, 04 Sep 2014 06:11:22 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20140904123224.GC25664@strange.ger.corp.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Thu, Sep 04, 2014 at 01:32:24PM +0100, Damien Lespiau wrote:
> On Thu, Sep 04, 2014 at 03:11:24PM +0300, Jani Nikula wrote:
> > On Thu, 04 Sep 2014, Damien Lespiau <damien.lespiau@intel.com> wrote:
> > > The new version of the macro does a few things better:
> > >   - protect the arguments,
> > >   - only evaluate the arguments once,
> > >   - check that the arguments are of the same type,
> > >
> > > Change LC_FREQ_2K to be a unsigned 64bit constant and removed the '()'
> > > from the caller as a result.
> > >
> > > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> > 
> > Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> > 
> > Can be picked up for dinq separate from this series, right?
> 
> Yes, it can indeed.

s/can/must/ If the platform enabling changes shared code, that part must
go in through the normal merge process and has the same merge window
cutoff deadlines like everything else.

Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch