From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42820)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ehabkost@redhat.com>) id 1XPZ6F-0001xs-Tx
	for qemu-devel@nongnu.org; Thu, 04 Sep 2014 11:37:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ehabkost@redhat.com>) id 1XPZ69-000220-PA
	for qemu-devel@nongnu.org; Thu, 04 Sep 2014 11:37:27 -0400
Received: from mx1.redhat.com ([209.132.183.28]:38744)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ehabkost@redhat.com>) id 1XPZ69-00021r-Gl
	for qemu-devel@nongnu.org; Thu, 04 Sep 2014 11:37:21 -0400
Date: Thu, 4 Sep 2014 12:37:11 -0300
From: Eduardo Habkost <ehabkost@redhat.com>
Message-ID: <20140904153711.GC8481@thinpad.lan.raisama.net>
References: <1407524611-10843-1-git-send-email-ehabkost@redhat.com>
	<20140821202615.GB12310@thinpad.lan.raisama.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20140821202615.GB12310@thinpad.lan.raisama.net>
Subject: Re: [Qemu-devel] [PATCH v3 0/6] Improve global validation test
 cases, move validation to a single function
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, "Michael S. Tsirkin" <mst@redhat.com>, Markus Armbruster <armbru@redhat.com>, Don Slutz <dslutz@verizon.com>, Paolo Bonzini <pbonzini@redhat.com>, Igor Mammedov <imammedo@redhat.com>, Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>

Ping, again?

If people are too busy to review the qdev changes, can we at least get
the unit test changes included?


On Thu, Aug 21, 2014 at 05:26:15PM -0300, Eduardo Habkost wrote:
> Ping?
> 
> On Fri, Aug 08, 2014 at 04:03:25PM -0300, Eduardo Habkost wrote:
> > New version of what was previously a single patch, submitted as:
> >   Subject: [PATCH v2] qdev: Move global validation to a single function
> > 
> > Now the test cases run in a subprocess, and we are ensuring the warning messages
> > are actually printed.
> > 
> > Eduardo Habkost (6):
> >   test-qdev-global-props: Trivial comment fix
> >   test-qdev-global-props: Run tests on subprocess
> >   test-qdev-global-props: Initialize not_used=true for all props
> >   test-qdev-global-props: Test handling of hotpluggable and non-device
> >     types
> >   qdev: Rename qdev_prop_check_global() to qdev_prop_check_globals()
> >   qdev: Move global validation to a single function
> > 
> >  hw/core/qdev-properties-system.c |  18 +----
> >  hw/core/qdev-properties.c        |  30 ++++++--
> >  include/hw/qdev-core.h           |  10 +--
> >  include/hw/qdev-properties.h     |   2 +-
> >  tests/test-qdev-global-props.c   | 159 ++++++++++++++++++++++++++++++++++++---
> >  vl.c                             |   2 +-
> >  6 files changed, 180 insertions(+), 41 deletions(-)
> > 
> > -- 
> > 1.9.3
> > 
> > 
> 
> -- 
> Eduardo
> 

-- 
Eduardo