All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: "Liu, Chuansheng" <chuansheng.liu@intel.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>,
	"luto@amacapital.net" <luto@amacapital.net>,
	"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Liu, Changcheng" <changcheng.liu@intel.com>,
	"Wang, Xiaoming" <xiaoming.wang@intel.com>,
	"Chakravarty, Souvik K" <souvik.k.chakravarty@intel.com>
Subject: Re: [PATCH 3/3] cpuidle: Using the wake_up_all_idle_cpus() to wake up all idle cpus
Date: Thu, 4 Sep 2014 17:47:10 +0200	[thread overview]
Message-ID: <20140904154710.GH346@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <27240C0AC20F114CBF8149A2696CBE4A01E6B3E3@SHSMSX101.ccr.corp.intel.com>

On Thu, Sep 04, 2014 at 01:39:38PM +0000, Liu, Chuansheng wrote:
> > So IIUC, kick_all_cpus_sync is a broken function, right ?

> kick_all_cpus_sync has other callers, and those other callers want the
> old behavior.  I think this should be a new function.

Correct, things like arch/powerpc/mm/pgtable_64.c:pmdp_clear_flush()
really want the old behaviour. It basically uses
local_irq_disable()/local_irq_enable() vs kick_all_cpus_sync() as a RCU
like serialization primitive.

  reply	other threads:[~2014-09-04 15:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-04  7:17 [PATCH 1/3] sched: Add new API wake_up_if_idle() to wake up the idle cpu Chuansheng Liu
2014-09-04  7:17 ` [PATCH 2/3] smp: Adding new function wake_up_all_idle_cpus() Chuansheng Liu
2014-09-04 12:56   ` Daniel Lezcano
2014-09-19 11:44   ` [tip:sched/core] smp: Add new wake_up_all_idle_cpus() function tip-bot for Chuansheng Liu
2014-09-04  7:17 ` [PATCH 3/3] cpuidle: Using the wake_up_all_idle_cpus() to wake up all idle cpus Chuansheng Liu
2014-09-04 13:01   ` Daniel Lezcano
2014-09-04 13:39     ` Liu, Chuansheng
2014-09-04 13:39       ` Liu, Chuansheng
2014-09-04 15:47       ` Peter Zijlstra [this message]
2014-09-19 11:44   ` [tip:sched/core] cpuidle: Use " tip-bot for Chuansheng Liu
2014-09-04 12:53 ` [PATCH 1/3] sched: Add new API wake_up_if_idle() to wake up the idle cpu Daniel Lezcano
2014-09-04 12:59   ` Liu, Chuansheng
2014-09-04 12:59     ` Liu, Chuansheng
2014-09-19 11:43 ` [tip:sched/core] " tip-bot for Chuansheng Liu
2014-12-19 20:23   ` Andy Lutomirski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140904154710.GH346@worktop.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=changcheng.liu@intel.com \
    --cc=chuansheng.liu@intel.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=mingo@redhat.com \
    --cc=rjw@rjwysocki.net \
    --cc=souvik.k.chakravarty@intel.com \
    --cc=xiaoming.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.