Re: [tisdk-build-scripts][PATCH 3/4] bitbake-test-sdk-image: Add support to control verbosity of build logging.

[Denys Dmytriyenko <denys@ti.com>]

Can you please elaborate on this change? You don't seem to be increasing 
Bitbake's verbosity level, just enabling capturing stdout and stderr into a 
file, which gets captured by results.html anyway. What's the purpose?


On Thu, Sep 04, 2014 at 01:31:07PM -0400, Jacob Stiffler wrote:
> * Setting BUILD_LOG_VERBOSE="true" (case sensitive) will enable logging stdout
>   and stderr for the bitbake command to the build log.
> 
> Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
> ---
>  lib/oesdk/bitbake-test-sdk-image |    8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/oesdk/bitbake-test-sdk-image b/lib/oesdk/bitbake-test-sdk-image
> index cff86e4..7d8d093 100644
> --- a/lib/oesdk/bitbake-test-sdk-image
> +++ b/lib/oesdk/bitbake-test-sdk-image
> @@ -375,12 +375,16 @@ bitbake_sdk_images(){
>          for c in "${bitbake_command_list[@]}"
>          do
>              log $machine_build_log echo "executing bitbake command $c for machine $m"
> -            MACHINE=$m EXTRA_TISDK_FILES="${INSTALLER_EXTRAS_ROOT}/${MACHINE}" TISDK_VERSION="${TISDK_VERSION}" bitbake $c
> +            if [ "${BUILD_LOG_VERBOSE}" = "true" ]; then
> +                MACHINE=$m EXTRA_TISDK_FILES="${INSTALLER_EXTRAS_ROOT}/${MACHINE}" TISDK_VERSION="${TISDK_VERSION}" bitbake $c 2>&1 | eval tee -a $machine_build_log
> +            else
> +                MACHINE=$m EXTRA_TISDK_FILES="${INSTALLER_EXTRAS_ROOT}/${MACHINE}" TISDK_VERSION="${TISDK_VERSION}" bitbake $c
> +            fi
>  
>              # Check the return status of the build process.  If the build returned
>              # a non-zero exit value then log the failure and continue (without
>              # testing).  A lack of a test file will indicate a test skip
> -            if [ "$?" != "0" ]
> +            if [ "${PIPESTATUS[0]}" != "0" ]
>              then
>                  echo "FAILED" > $LOG_DIR/$m-build-result.txt
>                  build_status="fail"
> -- 
> 1.7.9.5
> 
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago