From: Bjorn Helgaas <bhelgaas@google.com>
To: Quentin Lambert <lambert.quentin@gmail.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>, Scott Murray <scott@spiteful.org>,
linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] Fixing checkpatch errors and warnings for PCI hotplug
Date: Thu, 4 Sep 2014 15:23:50 -0600 [thread overview]
Message-ID: <20140904212350.GE17125@google.com> (raw)
In-Reply-To: <20140804185923.GA4185@greed>
On Mon, Aug 04, 2014 at 08:59:23PM +0200, Quentin Lambert wrote:
> Patch 1 and 2 fix checkpatch coding style warnings.
>
> Patch 3 fixes chechpatch errors due to assignement
> in if conditions.
>
>
> Quentin Lambert (3):
> PCI hotplug: fix a missing space coding style issue
> PCI hotplug: fix a simple if coding style issue
> PCI hotplug: remove assignement from if conditions
I don't mind doing changes like these, but when we do, I want to do the
whole drivers/pci directory at once to minimize the churn. I don't know
how you did these, but it looks like there are more instances than are
fixed by these patches, e.g.,
drivers/pci/hotplug/cpcihp_generic.c: if(!bridge) {
drivers/pci/pci.c: if ((i = pci_save_pcie_state(dev)) != 0)
prev parent reply other threads:[~2014-09-04 21:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-04 18:59 [PATCH 0/3] Fixing checkpatch errors and warnings for PCI hotplug Quentin Lambert
2014-09-04 21:23 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140904212350.GE17125@google.com \
--to=bhelgaas@google.com \
--cc=lambert.quentin@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=scott@spiteful.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.