Re: [GIT PULL] Staging driver patches for 3.15-rc1

[Greg KH <gregkh@linuxfoundation.org>]

On Fri, Sep 05, 2014 at 01:13:55AM +0200, Paul Bolle wrote:
> On Wed, 2014-04-02 at 16:08 -0700, Greg KH wrote:
> > On Wed, Apr 02, 2014 at 08:52:18PM +0000, Insop Song wrote:
> > > On Wed, April 02, 2014 1:04 PM, Greg KH wrote:
> > > > On Wed, Apr 02, 2014 at 10:24:03AM +0200, Paul Bolle wrote:
> > > > > On Tue, 2014-04-01 at 11:48 -0700, Greg KH wrote:
> > > > > > Staging driver pull request for 3.15-rc1
> > > > > >
> > > > > > Here's the huge drivers/staging/ update for 3.15-rc1.
> > > > > >
> > > > > > Loads of cleanup fixes, a few drivers removed, and some new ones
> > > > added.
> > > > > >
> > > > > > All have been in linux-next for a while.
> > > > > >
> > > > > >[...]
> > > > > >
> > > > > > Insop Song (1):
> > > > > >       staging: fpgaboot: Xilinx FPGA firmware download driver
> > > > >
> > > > > This commit adds checks for CONFIG_B4860G100. Is a patch to add a
> > > > > Kconfig symbol B4860G100 perhaps queued somewhere?
> > > > 
> > > > Insop, I thought this config option was coming from some other place, right?
> > > > 
> > > 
> > > Paul,
> > > I didn't include CONFIG_B4860G100 in Kconfig in original patch set,
> > > since programming FPGA method can vary in different system, and this
> > > was discussed during the review with Greg as well.
> > > 
> > > However, actual fpga programming method is well contained in io.c with
> > > ifdef-ed CONFIG_B4860G100, now I think I might better to update
> > > Kconfig to include CONFIG_B4860G100.
> > > 
> > > Greg, what do you think? Any harm to add custom board CONFIG* to
> > > staging Kconfig? Let me know.
> > 
> > Let's see what it would look like and we can go from there.
> 
> Nothing appears to have changed: there are still checks for
> CONFIG_B4860G100 in next-20140904. Should I submit the trivial patch to
> remove those checks and the code they hide?

Yes, please do.

thanks,

greg k-h