From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Turquette Subject: Re: [PATCH v9 2/3] clk: RK808: Add clkout driver for RK808 Date: Thu, 04 Sep 2014 18:35:13 -0700 Message-ID: <20140905013513.11368.8329@quantum> References: <1409793159-2573-1-git-send-email-zyw@rock-chips.com> <1409793159-2573-3-git-send-email-zyw@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: <1409793159-2573-3-git-send-email-zyw-TNX95d0MmH7DzftRWevZcw@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, hl-TNX95d0MmH7DzftRWevZcw@public.gmane.org, huangtao-TNX95d0MmH7DzftRWevZcw@public.gmane.org, cf-TNX95d0MmH7DzftRWevZcw@public.gmane.org, zhangqing-TNX95d0MmH7DzftRWevZcw@public.gmane.org, xxx-TNX95d0MmH7DzftRWevZcw@public.gmane.org, olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org, sonnyrao-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, dtor-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org, kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org, Chris Zhong List-Id: devicetree@vger.kernel.org Quoting Chris Zhong (2014-09-03 18:12:38) > +static int rk808_clkout1_is_prepared(struct clk_hw *hw) > +{ > + return 1; > +} > + > +static const struct clk_ops rk808_clkout1_ops = { > + .is_prepared = rk808_clkout1_is_prepared, > + .recalc_rate = rk808_clkout_recalc_rate, > +}; Hi Chris, I do not see a need clkout1 to have a .is_prepared callback. You should be fine only having a .recalc_rate. Regards, Mike -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755546AbaIEBfa (ORCPT ); Thu, 4 Sep 2014 21:35:30 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:63538 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750966AbaIEBf1 convert rfc822-to-8bit (ORCPT ); Thu, 4 Sep 2014 21:35:27 -0400 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT To: Chris Zhong , dianders@chromium.org, heiko@sntech.de From: Mike Turquette In-Reply-To: <1409793159-2573-3-git-send-email-zyw@rock-chips.com> Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, sameo@linux.intel.com, lee.jones@linaro.org, lgirdwood@gmail.com, a.zummo@towertech.it, akpm@linux-foundation.org, broonie@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com, grant.likely@linaro.org, hl@rock-chips.com, huangtao@rock-chips.com, cf@rock-chips.com, zhangqing@rock-chips.com, xxx@rock-chips.com, olof@lixom.net, sonnyrao@chromium.org, dtor@chromium.org, javier.martinez@collabora.co.uk, kever.yang@rock-chips.com, "Chris Zhong" References: <1409793159-2573-1-git-send-email-zyw@rock-chips.com> <1409793159-2573-3-git-send-email-zyw@rock-chips.com> Message-ID: <20140905013513.11368.8329@quantum> User-Agent: alot/0.3.5 Subject: Re: [PATCH v9 2/3] clk: RK808: Add clkout driver for RK808 Date: Thu, 04 Sep 2014 18:35:13 -0700 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Chris Zhong (2014-09-03 18:12:38) > +static int rk808_clkout1_is_prepared(struct clk_hw *hw) > +{ > + return 1; > +} > + > +static const struct clk_ops rk808_clkout1_ops = { > + .is_prepared = rk808_clkout1_is_prepared, > + .recalc_rate = rk808_clkout_recalc_rate, > +}; Hi Chris, I do not see a need clkout1 to have a .is_prepared callback. You should be fine only having a .recalc_rate. Regards, Mike