From: Johan Hedberg <johan.hedberg@gmail.com>
To: 陈艳萍 <champion_chen@realsil.com.cn>
Cc: "Larry Finger" <Larry.Finger@lwfinger.net>,
"Daniel Drake" <drake@endlessm.com>,
"Marcel Holtmann" <marcel@holtmann.org>,
"Gustavo F. Padovan" <gustavo@padovan.org>,
"Linux Bluetooth mailing list" <linux-bluetooth@vger.kernel.org>,
许凯凯 <kyle_xu@realsil.com.cn>
Subject: Re: 答复: 答复: 答复: [PATCH v2] Bluetooth: btusb: Add Realtek 8723/8761 support
Date: Fri, 5 Sep 2014 10:56:27 +0300 [thread overview]
Message-ID: <20140905075627.GA8504@t440s> (raw)
In-Reply-To: <54F70642BAB21D4498E1AA3EFE3D519A460112CB@rsex2.realsil.com.cn>
Hi Champion,
On Fri, Sep 05, 2014, 陈艳萍 wrote:
> We found there was chance suspend failed in some platform.
> This is because btusb_suspend==> btusb_stop_traffic ==> usb_kill_anchored_urbs,
>
> btusb_bulk_complete sometimes returns before system suspend and
> resubmit an urb, this will avoid system enter suspend state.
> I don't know whether this is the platform issue, there is a method to
> fix this by attached file.
This looks like a potentially good fix for btusb, however could you
please provide your patches in the format expected by upstream, i.e.
what you get with proper commits/commit messages and then sending the
patches using git format-patch and git send-email? The same applies for
any other patches you have for upstream inclusion. You'll also want to
ensure that the coding style is correct by reading
Documentation/CodingStyle and running scripts/checkpatch.pl on your
patches.
Johan
prev parent reply other threads:[~2014-09-05 7:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 12:47 [PATCH v2] Bluetooth: btusb: Add Realtek 8723/8761 support Daniel Drake
2014-07-01 13:41 ` Marcel Holtmann
2014-07-01 14:18 ` Daniel Drake
2014-07-01 15:18 ` Larry Finger
2014-07-01 15:27 ` Marcel Holtmann
2014-07-03 9:28 ` 答复: " 陈艳萍
2014-07-03 18:12 ` Marcel Holtmann
2014-07-04 10:11 ` 答复: " 陈艳萍
2014-07-08 7:57 ` Daniel Drake
2014-07-11 8:44 ` 答复: " 陈艳萍
2014-07-11 9:11 ` Daniel Drake
2014-07-11 9:58 ` 答复: " 陈艳萍
2014-07-11 11:19 ` Marcel Holtmann
2014-09-04 3:34 ` 答复: 答复: " 陈艳萍
2014-09-04 12:34 ` Daniel Drake
2014-09-04 16:42 ` Larry Finger
2014-09-05 3:30 ` 答复: " 陈艳萍
2014-09-05 7:56 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140905075627.GA8504@t440s \
--to=johan.hedberg@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=champion_chen@realsil.com.cn \
--cc=drake@endlessm.com \
--cc=gustavo@padovan.org \
--cc=kyle_xu@realsil.com.cn \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.