From: Pavel Machek <pavel@ucw.cz>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-pm@vger.kernel.org, Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH] PM / sysfs: avoid shadowing variables
Date: Sat, 6 Sep 2014 22:12:44 +0200 [thread overview]
Message-ID: <20140906201244.GA12554@amd> (raw)
In-Reply-To: <1409902505-31549-1-git-send-email-johannes@sipsolutions.net>
On Fri 2014-09-05 09:35:05, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> The global variable "enabled" is shadowed in a number of
> functions in this file, rename it to "_enabled" to avoid
> that. For consistency, also rename "disabled" and move
> them both into the #ifdef where they're needed.
>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
prev parent reply other threads:[~2014-09-06 20:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-05 7:35 [PATCH] PM / sysfs: avoid shadowing variables Johannes Berg
2014-09-06 20:12 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140906201244.GA12554@amd \
--to=pavel@ucw.cz \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.