From: Mark Brown <broonie@kernel.org>
To: Axel Lin <axel.lin@ingics.com>
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Liam Girdwood <lgirdwood@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] regulator: as3711: Remove unused fields from as3711_regulator_info and as3711_regulator
Date: Sun, 7 Sep 2014 16:04:29 +0100 [thread overview]
Message-ID: <20140907150429.GL2601@sirena.org.uk> (raw)
In-Reply-To: <1410086091.4121.1.camel@phoenix>
[-- Attachment #1: Type: text/plain, Size: 539 bytes --]
On Sun, Sep 07, 2014 at 06:34:51PM +0800, Axel Lin wrote:
> The max_uV is not used, so remove it from struct as3711_regulator_info.
> Current code is using devm_regulator_register(), so we don't need to store *rdev
> in struct as3711_regulator for clean up.
> Also clean up AS3711_REG macro to remove _vshift, _min_uV and _max_uV arguments.
> _vshift is always 0, so remove it.
> _min_uV and _max_uV are not required, all required settings are set in
> REGULATOR_LINEAR_RANGE macro.
Applied, but these should really be separate patches.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-09-07 15:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-07 10:34 [PATCH] regulator: as3711: Remove unused fields from as3711_regulator_info and as3711_regulator Axel Lin
2014-09-07 15:04 ` Mark Brown [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-09-06 13:17 Axel Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140907150429.GL2601@sirena.org.uk \
--to=broonie@kernel.org \
--cc=axel.lin@ingics.com \
--cc=g.liakhovetski@gmx.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.