From: Christoph Hellwig <hch@infradead.org>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1/6] pnfs: enable CB_NOTIFY_DEVICEID support
Date: Sun, 7 Sep 2014 10:50:28 -0700 [thread overview]
Message-ID: <20140907175028.GA27934@infradead.org> (raw)
In-Reply-To: <1409719119-2110-2-git-send-email-hch@lst.de>
On Tue, Sep 02, 2014 at 09:38:34PM -0700, Christoph Hellwig wrote:
> This code has been around for a while, but never was enabled. Turns out it
> really does work out of the box at least for the block layout driver, so
> we just need to wire it up, and in case of NOTIFY_DEVICEID4_CHANGE remove
> a conditional that returns an error.
>
> Note that we implement NOTIFY_DEVICEID4_CHANGE identical to
> NOTIFY_DEVICEID4_DELETE. Given that in either case we can't do anything
> but preventing further lookups of a given device ID there isn't much difference
> in semantics for the two. For the delete case the server MUST ensure that
> there are no outstanding layouts, while for the change case it doesn't, but
> that has little relevance to the client.
I got a comment that we should probably just enable CB_NOTIFY_DEVICEID
for all layout types unconditionally as there really isn't anything
layout type specific in it. I'm tempted to agree, so if anyone
disagrees speak up now, or I'll resend it that way in a few days.
next prev parent reply other threads:[~2014-09-07 17:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-03 4:38 pnfs: add CB_NOTIFY_DEVICEID support Christoph Hellwig
2014-09-03 4:38 ` [PATCH 1/6] pnfs: enable " Christoph Hellwig
2014-09-07 17:50 ` Christoph Hellwig [this message]
2014-09-03 4:38 ` [PATCH 2/6] pnfs/blocklayout: move extent processing to blocklayout.c Christoph Hellwig
2014-09-03 4:38 ` [PATCH 3/6] pnfs/blocklayout: refactor extent processing Christoph Hellwig
2014-09-03 4:38 ` [PATCH 4/6] pnfs/blocklayout: move all rpc_pipefs related code into a single file Christoph Hellwig
2014-09-03 4:38 ` [PATCH 5/6] pnfs/blocklayout: in-kernel GETDEVICEINFO XDR parsing Christoph Hellwig
2014-09-03 19:31 ` Anna Schumaker
2014-09-04 1:38 ` Christoph Hellwig
2014-09-03 4:38 ` [PATCH 6/6] pnfs/blocklayout: ask for NOTIFY_DEVICEID callbacks Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140907175028.GA27934@infradead.org \
--to=hch@infradead.org \
--cc=hch@lst.de \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.