From: Theodore Ts'o <tytso@mit.edu>
To: Christoph Hellwig <hch@infradead.org>
Cc: fstests@vger.kernel.org,
Ext4 Developers List <linux-ext4@vger.kernel.org>,
Xiaoguang Wang <wangxg.fnst@cn.fujitsu.com>,
Eryu Guan <eguan@redhat.com>
Subject: Re: [PATCH] ext4: use mkfs.ext4 -F instead of piping in yes
Date: Sun, 7 Sep 2014 15:21:10 -0400 [thread overview]
Message-ID: <20140907192110.GC1066@thunk.org> (raw)
In-Reply-To: <20140907154927.GA23630@infradead.org>
On Sun, Sep 07, 2014 at 08:49:27AM -0700, Christoph Hellwig wrote:
> On Sun, Sep 07, 2014 at 08:29:02AM -0400, Theodore Ts'o wrote:
> > Using "yes | mkfs.ext4 ..." results in the error message results in
> > the test failing, at least for some versions of e2fsprogs:
> >
> > +yes: standard output: Broken pipe
> > +yes: write error
> >
> > It better to use the -F option, which will eliminate the questions.
>
> Looks good, but maybe we should have a $MKFS_EXT4_PROG variable similar
> to $MKFS_XFS_PROG so that we can set this in one place?
Agreed, I'll send a separate patch to fix that. One amusing thing:
% git grep mkfs.ext4
common/rc:_scratch_mkfs_ext4()
common/rc: _scratch_mkfs_ext4 $*
common/rc:# this test requires the bigalloc feature to be available in mkfs.ext4
common/rc: _scratch_mkfs_ext4 -O bigalloc >/dev/null 2>&1 \
common/rc: || _notrun "mkfs.ext4 doesn't have bigalloc feature"
common/rc: _scratch_mkfs_ext4 -O bigalloc >/dev/null 2>&1
tests/btrfs/012:MKFS_EXT4_PROG="`set_prog_path mkfs.ext4`"
tests/btrfs/012:_require_command $MKFS_EXT4_PROG mkfs.ext4
tests/ext4/003:mkfs.ext4 -F -O bigalloc -C 65536 -g 256 $SCRATCH_DEV 512m \
tests/ext4/306:mkfs.ext4 -F -O ^extents,^64bit $SCRATCH_DEV 512m >> $seqres.full 2>&1
(note the btrfs test is the one place using and defining MKFS_EXT4_PROG :-)
- Ted
next prev parent reply other threads:[~2014-09-07 19:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-07 12:29 [PATCH] ext4: use mkfs.ext4 -F instead of piping in yes Theodore Ts'o
2014-09-07 15:49 ` Christoph Hellwig
2014-09-07 19:21 ` Theodore Ts'o [this message]
2014-09-08 2:06 ` [PATCH 1/2] ext4: define MKFS_EXT4_PROG and use it instead of "mkfs.ext4" / "mkfs -t ext4" Theodore Ts'o
2014-09-08 2:06 ` [PATCH 2/2] ext4: speed up _require_ext4_bigalloc and _require_ext4_mkfs_bigalloc Theodore Ts'o
2014-09-08 9:50 ` Dave Chinner
2014-09-08 12:02 ` Theodore Ts'o
2014-09-08 12:15 ` [PATCH -v2] " Theodore Ts'o
2014-09-08 12:36 ` Dave Chinner
2014-09-08 12:39 ` Theodore Ts'o
2014-09-08 12:50 ` Dave Chinner
2014-09-08 12:35 ` [PATCH 1/2] ext4: define MKFS_EXT4_PROG and use it instead of "mkfs.ext4" / "mkfs -t ext4" Dave Chinner
2014-09-27 0:11 ` Dave Chinner
2014-09-27 22:12 ` Theodore Ts'o
2014-09-27 22:17 ` [PATCH 1/3] " Theodore Ts'o
2014-09-27 22:17 ` [PATCH 2/3] ext4: use mkfs.ext4 -F instead of piping in yes Theodore Ts'o
2014-09-27 22:17 ` [PATCH 3/3] ext4: speed up _require_ext4_bigalloc and _require_ext4_mkfs_bigalloc Theodore Ts'o
2014-09-09 11:49 ` [PATCH] ext4: use mkfs.ext4 -F instead of piping in yes Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140907192110.GC1066@thunk.org \
--to=tytso@mit.edu \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=hch@infradead.org \
--cc=linux-ext4@vger.kernel.org \
--cc=wangxg.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.