From: David Gibson <david@gibson.dropbear.id.au>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH] spapr: Fix spapr_populate_memory() to compile on windows
Date: Mon, 8 Sep 2014 13:03:37 +1000 [thread overview]
Message-ID: <20140908030337.GB4776@voom.redhat.com> (raw)
In-Reply-To: <1410134344-30803-1-git-send-email-aik@ozlabs.ru>
[-- Attachment #1: Type: text/plain, Size: 622 bytes --]
On Mon, Sep 08, 2014 at 09:59:04AM +1000, Alexey Kardashevskiy wrote:
> This replaces gcc's ffsl() function ("find first bit set in a word")
> with QEMU's ctzl ("count trailing zeros"). There are no corner cases
> in the affected code so simple replacement ffsl()-1 by ctzl() works.
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Looks sane to me.
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-09-08 3:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-07 23:59 [Qemu-devel] [PATCH] spapr: Fix spapr_populate_memory() to compile on windows Alexey Kardashevskiy
2014-09-08 3:03 ` David Gibson [this message]
2014-09-08 10:50 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140908030337.GB4776@voom.redhat.com \
--to=david@gibson.dropbear.id.au \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.