Re: [PATCH v3 1/4] Add a Firmware programming framework

[Sascha Hauer <s.hauer@pengutronix.de>]

On Thu, Sep 04, 2014 at 03:47:14PM +0200, Steffen Trumtrar wrote:
> +/*
> + * firmwaremgr_list_handlers - list registered firmware device handlers
> + *                             in pretty format
> + */
> +void firmwaremgr_list_handlers(void)
> +{
> +	struct firmware_mgr *mgr;
> +
> +	printf("firmware programming handlers:\n\n");
> +
> +	if (list_empty(&firmwaremgr_list)) {
> +		printf("(none)\n");
> +		return;
> +	}
> +
> +	printf("%-11s%-11s\n", "name:", "model:");
> +
> +	list_for_each_entry(mgr, &firmwaremgr_list, list) {
> +		printf("%-11s", mgr->handler->id);
> +		if (mgr->handler->model)
> +			printf("%-11s", mgr->handler->model);
> +		printf("\n");

You should add a whitespace between both %-11s. Otherwise there won't be
any whitespace between the strings when they are longer than 11 chars.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox