From: Mel Gorman <mgorman@suse.de>
To: Christoph Lameter <cl@linux.com>
Cc: Tejun Heo <tj@kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] percpu: Resolve ambiguities in __get_cpu_var/cpumask_var_t -fix
Date: Mon, 8 Sep 2014 23:06:54 +0100 [thread overview]
Message-ID: <20140908220654.GO17501@suse.de> (raw)
A commit in linux-next was causing boot to fail and bisection identified
the patch "percpu: Resolve ambiguities in __get_cpu_var/cpumask_var_".
The commit ID is worthless as it's a linux-next commit. One of the changes
in that patch looks very suspicious. Reverting the full patch fixes boot
as does this fixlet.
Signed-off-by: Mel Gorman <mgorman@suse.de>
---
arch/x86/kernel/apic/x2apic_cluster.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/kernel/apic/x2apic_cluster.c b/arch/x86/kernel/apic/x2apic_cluster.c
index 1f5d5f2..e658f21 100644
--- a/arch/x86/kernel/apic/x2apic_cluster.c
+++ b/arch/x86/kernel/apic/x2apic_cluster.c
@@ -43,6 +43,7 @@ __x2apic_send_IPI_mask(const struct cpumask *mask, int vector, int apic_dest)
* and be sure it's manipulated with irq off.
*/
ipi_mask_ptr = this_cpu_cpumask_var_ptr(ipi_mask);
+ cpumask_copy(ipi_mask_ptr, mask);
/*
* The idea is to send one IPI per cluster.
next reply other threads:[~2014-09-08 22:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-08 22:06 Mel Gorman [this message]
2014-09-08 22:14 ` [PATCH] percpu: Resolve ambiguities in __get_cpu_var/cpumask_var_t -fix Tejun Heo
2014-09-08 23:46 ` Christoph Lameter
2014-09-09 0:35 ` Tejun Heo
2014-09-09 5:55 ` Ted Percival
2014-09-09 0:21 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140908220654.GO17501@suse.de \
--to=mgorman@suse.de \
--cc=cl@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.