From: Dave Chinner <david@fromorbit.com>
To: Brian Foster <bfoster@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: mark all internal workqueues as freezable
Date: Tue, 9 Sep 2014 11:46:17 +1000 [thread overview]
Message-ID: <20140909014617.GT30012@dastard> (raw)
In-Reply-To: <1408388523-3684-1-git-send-email-bfoster@redhat.com>
On Mon, Aug 18, 2014 at 03:02:03PM -0400, Brian Foster wrote:
> Workqueues must be explicitly set as freezable to ensure they are frozen
> in the assocated part of the hibernation/suspend sequence. Freezing of
> workqueues and kernel threads is important to ensure that modifications
> are not made on-disk after the hibernation image has been created.
> Otherwise, the in-memory state can become inconsistent with what is on
> disk and eventually lead to filesystem corruption. We have reports of
> free space btree corruptions that occur immediately after restore from
> hibernate that suggest the xfs-eofblocks workqueue could be causing
> such problems if it races with hibernation.
>
> Mark all of the internal XFS workqueues as freezable to ensure nothing
> changes on-disk once the freezer infrastructure freezes kernel threads
> and creates the hibernation image.
>
> Signed-off-by: Brian Foster <bfoster@redhat.com>
> Reported-by: Carlos E. R. <carlos.e.r@opensuse.org>
Looks good.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-09-09 1:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-18 19:02 [PATCH] xfs: mark all internal workqueues as freezable Brian Foster
2014-09-09 1:46 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140909014617.GT30012@dastard \
--to=david@fromorbit.com \
--cc=bfoster@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.