Re: [libvirt] [libvirt bisection] complete build-armhf-libvirt

["Daniel P. Berrange" <berrange@redhat.com>]

On Tue, Sep 09, 2014 at 09:49:47AM +0100, Ian Campbell wrote:
> Xen's automated testing of libvirt against newer Xen's has found a build
> issue which it has bisected down to "blockcopy: expose new API in
> virsh".
> 
> An instance of the failure can be found in flight 30154:
> http://lists.xen.org/archives/html/xen-devel/2014-09/msg01063.html
> 	links to the logs =>
> http://www.chiark.greenend.org.uk/~xensrcts/logs/30154/
> 	click the header of a failing column =>
> http://www.chiark.greenend.org.uk/~xensrcts/logs/30154/build-armhf-libvirt/info.html 
> 	click the failing step =>
> http://www.chiark.greenend.org.uk/~xensrcts/logs/30154/build-armhf-libvirt/5.ts-libvirt-build.log
> 
>         virsh-domain.c: In function 'cmdBlockCopy':
>         virsh-domain.c:2003:17: error: comparison is always false due to limited range of data type [-Werror=type-limits]
>         cc1: all warnings being treated as errors
> 
> It seems to be failing similarly on i386 and I suppose most 32-bit
> arches.

Thanks, we've just had a fix for that pushed

  commit efe5061f5a61d04b1bf21fcac2919a2325f54150
  Author: Eric Blake <eblake@redhat.com>
  Date:   Mon Sep 8 08:50:48 2014 -0600

    blockjob: avoid 32-bit compilation warning
    
    Commit c1d75de caused this warning on 32-bit platforms (fatal when
    -Werror is enabled):
    
    virsh-domain.c: In function 'cmdBlockCopy':
    virsh-domain.c:2003:17: error: comparison is always false due to limited range of data type [-Werror=type-
    
    Forcing the left side of the < to be ull instead of ul shuts up
    the 32-bit compiler while still protecting 64-bit code from overflow.
    

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|