From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH V1] ASoC: fsl_ssi: refine ipg clock usage in this module Date: Tue, 9 Sep 2014 12:27:50 +0100 Message-ID: <20140909112750.GS2601@sirena.org.uk> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0508152607389354593==" Return-path: Received: from mezzanine.sirena.org.uk (mezzanine.sirena.org.uk [106.187.55.193]) by alsa0.perex.cz (Postfix) with ESMTP id 4FBE7264F0F for ; Tue, 9 Sep 2014 13:28:08 +0200 (CEST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Shengjiu Wang Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com, tiwai@suse.de, linux-kernel@vger.kernel.org, timur@tabi.org, nicoleotsuka@gmail.com, Li.Xiubo@freescale.com, linuxppc-dev@lists.ozlabs.org List-Id: alsa-devel@alsa-project.org --===============0508152607389354593== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="NKys6zTV8iyMJiwY" Content-Disposition: inline --NKys6zTV8iyMJiwY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Sep 09, 2014 at 05:18:07PM +0800, Shengjiu Wang wrote: > + if (ssi_private->soc->imx) > + clk_prepare_enable(ssi_private->clk); > + We're ignoring the error code here. > - ssi_private->clk = devm_clk_get(&pdev->dev, NULL); > + ssi_private->clk = devm_clk_get(&pdev->dev, "ipg"); > if (IS_ERR(ssi_private->clk)) { > ret = PTR_ERR(ssi_private->clk); > - dev_err(&pdev->dev, "could not get clock: %d\n", ret); > - return ret; Why is this change being made? It wasn't mentioned in the commit log and doesn't seem relevant to moving where the enable and disable are done which is what the patch is supposed to be doing... Please don't make different changes in the same patch. --NKys6zTV8iyMJiwY Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJUDuQ1AAoJECTWi3JdVIfQRFUH/A+c1fwfvIqcmYIlaJcAiWkO Uuq0EjAEHWoUitSMxR1m/fvZ/UYttYAxEv/hl6HjFyhUlVyVklJ8jmtOlWpGfpIX ZlisKPVpCFiE2bUdjjNxNvuVxu53MRUC6hmyDWiMN43UUNiBlYRpJrm+WKf0j8PB o1nGbFVrfp5xOUAly951EFXBgC5PDPMZIY8XgL3pH6HesIv3URAxlL8JeguIuSWM eM0i3O90aPHcfjKNT89fMru4Jhcw1jARkF9lE63EHXhbOnq+TDbWfIZKeYpNLoem mB38k6NQH9IoFvr9kIoVqa9xLgP/c6da1w+3as8s40YPNfFVFeoKikKhBNsQuNQ= =R1az -----END PGP SIGNATURE----- --NKys6zTV8iyMJiwY-- --===============0508152607389354593== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============0508152607389354593==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mezzanine.sirena.org.uk (mezzanine.sirena.org.uk [IPv6:2400:8900::f03c:91ff:fedb:4f4]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4E16B1A0044 for ; Tue, 9 Sep 2014 21:28:11 +1000 (EST) Date: Tue, 9 Sep 2014 12:27:50 +0100 From: Mark Brown To: Shengjiu Wang Message-ID: <20140909112750.GS2601@sirena.org.uk> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="NKys6zTV8iyMJiwY" In-Reply-To: Subject: Re: [PATCH V1] ASoC: fsl_ssi: refine ipg clock usage in this module Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com, tiwai@suse.de, linux-kernel@vger.kernel.org, timur@tabi.org, perex@perex.cz, nicoleotsuka@gmail.com, Li.Xiubo@freescale.com, linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , --NKys6zTV8iyMJiwY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Sep 09, 2014 at 05:18:07PM +0800, Shengjiu Wang wrote: > + if (ssi_private->soc->imx) > + clk_prepare_enable(ssi_private->clk); > + We're ignoring the error code here. > - ssi_private->clk = devm_clk_get(&pdev->dev, NULL); > + ssi_private->clk = devm_clk_get(&pdev->dev, "ipg"); > if (IS_ERR(ssi_private->clk)) { > ret = PTR_ERR(ssi_private->clk); > - dev_err(&pdev->dev, "could not get clock: %d\n", ret); > - return ret; Why is this change being made? It wasn't mentioned in the commit log and doesn't seem relevant to moving where the enable and disable are done which is what the patch is supposed to be doing... Please don't make different changes in the same patch. --NKys6zTV8iyMJiwY Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJUDuQ1AAoJECTWi3JdVIfQRFUH/A+c1fwfvIqcmYIlaJcAiWkO Uuq0EjAEHWoUitSMxR1m/fvZ/UYttYAxEv/hl6HjFyhUlVyVklJ8jmtOlWpGfpIX ZlisKPVpCFiE2bUdjjNxNvuVxu53MRUC6hmyDWiMN43UUNiBlYRpJrm+WKf0j8PB o1nGbFVrfp5xOUAly951EFXBgC5PDPMZIY8XgL3pH6HesIv3URAxlL8JeguIuSWM eM0i3O90aPHcfjKNT89fMru4Jhcw1jARkF9lE63EHXhbOnq+TDbWfIZKeYpNLoem mB38k6NQH9IoFvr9kIoVqa9xLgP/c6da1w+3as8s40YPNfFVFeoKikKhBNsQuNQ= =R1az -----END PGP SIGNATURE----- --NKys6zTV8iyMJiwY-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932212AbaIIL2N (ORCPT ); Tue, 9 Sep 2014 07:28:13 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:58816 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756245AbaIIL2L (ORCPT ); Tue, 9 Sep 2014 07:28:11 -0400 Date: Tue, 9 Sep 2014 12:27:50 +0100 From: Mark Brown To: Shengjiu Wang Cc: timur@tabi.org, nicoleotsuka@gmail.com, Li.Xiubo@freescale.com, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.de, alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Message-ID: <20140909112750.GS2601@sirena.org.uk> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="NKys6zTV8iyMJiwY" Content-Disposition: inline In-Reply-To: X-Cookie: Exercise caution in your daily affairs. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 109.152.174.147 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH V1] ASoC: fsl_ssi: refine ipg clock usage in this module X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --NKys6zTV8iyMJiwY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Sep 09, 2014 at 05:18:07PM +0800, Shengjiu Wang wrote: > + if (ssi_private->soc->imx) > + clk_prepare_enable(ssi_private->clk); > + We're ignoring the error code here. > - ssi_private->clk = devm_clk_get(&pdev->dev, NULL); > + ssi_private->clk = devm_clk_get(&pdev->dev, "ipg"); > if (IS_ERR(ssi_private->clk)) { > ret = PTR_ERR(ssi_private->clk); > - dev_err(&pdev->dev, "could not get clock: %d\n", ret); > - return ret; Why is this change being made? It wasn't mentioned in the commit log and doesn't seem relevant to moving where the enable and disable are done which is what the patch is supposed to be doing... Please don't make different changes in the same patch. --NKys6zTV8iyMJiwY Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJUDuQ1AAoJECTWi3JdVIfQRFUH/A+c1fwfvIqcmYIlaJcAiWkO Uuq0EjAEHWoUitSMxR1m/fvZ/UYttYAxEv/hl6HjFyhUlVyVklJ8jmtOlWpGfpIX ZlisKPVpCFiE2bUdjjNxNvuVxu53MRUC6hmyDWiMN43UUNiBlYRpJrm+WKf0j8PB o1nGbFVrfp5xOUAly951EFXBgC5PDPMZIY8XgL3pH6HesIv3URAxlL8JeguIuSWM eM0i3O90aPHcfjKNT89fMru4Jhcw1jARkF9lE63EHXhbOnq+TDbWfIZKeYpNLoem mB38k6NQH9IoFvr9kIoVqa9xLgP/c6da1w+3as8s40YPNfFVFeoKikKhBNsQuNQ= =R1az -----END PGP SIGNATURE----- --NKys6zTV8iyMJiwY--