All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Anna Schumaker <Anna.Schumaker@netapp.com>
Cc: Trond.Myklebust@primarydata.com, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1/2] nfs: Add ALLOCATE support
Date: Tue, 9 Sep 2014 08:59:41 -0700	[thread overview]
Message-ID: <20140909155941.GA6185@infradead.org> (raw)
In-Reply-To: <1410274196-30841-2-git-send-email-Anna.Schumaker@Netapp.com>

On Tue, Sep 09, 2014 at 10:49:55AM -0400, Anna Schumaker wrote:
> +	struct nfs_server *server = NFS_SERVER(inode);
> +	long ret = -EOPNOTSUPP;
> +
> +	if (server->caps & NFS_CAP_ALLOCATE) {
> +		ret = nfs42_proc_allocate(inode, stateid, offset, len);
> +		if (ret == -EOPNOTSUPP)
> +			server->caps &= ~NFS_CAP_ALLOCATE;
> +	}

So if we want clients to allow this sort of optimization we can't return
NFSERR_PNOTSUPP if it's called on the "wrong" kind of file.  Back to the
drawing board on that one.


  reply	other threads:[~2014-09-09 15:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-09 14:49 [PATCH 0/2] NFS: Add ALLOCATE and DEALLOCATE support Anna Schumaker
2014-09-09 14:49 ` [PATCH 1/2] nfs: Add ALLOCATE support Anna Schumaker
2014-09-09 15:59   ` Christoph Hellwig [this message]
2014-09-09 14:49 ` [PATCH 2/2] nfs: Add DEALLOCATE support Anna Schumaker
2014-09-09 17:37 ` [PATCH 0/2] NFS: Add ALLOCATE and " Marc Eshel
2014-09-09 17:46   ` Anna Schumaker
2014-09-09 17:48   ` Anna Schumaker
2014-09-09 18:01 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140909155941.GA6185@infradead.org \
    --to=hch@infradead.org \
    --cc=Anna.Schumaker@netapp.com \
    --cc=Trond.Myklebust@primarydata.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.