All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] commit 83e359adf9f578a58f20daf2e4425a754defac7b breaks mmc
Date: Tue, 9 Sep 2014 12:27:54 -0500	[thread overview]
Message-ID: <20140909172754.GS6151@saruman.home> (raw)
In-Reply-To: <20140909170902.GR6151@saruman.home>

Hi,

On Tue, Sep 09, 2014 at 12:09:02PM -0500, Felipe Balbi wrote:
> Hi,
> 
> commit 83e359a (am335x_evm: Enable CONFIG_SPL_ENV_SUPPORT on EMMC_BOOT)
> breaks MMC on some boards. I believe it only breaks if EMMC has no
> partition on it, so that would point out to a bug on spl env support
> itself and this has only exposed it.
> 
> Here's a bisection log anyway:
> 
> git bisect start
> # good: [524123a70761110c5cf3ccc5f52f6d4da071b959] Prepare v2014.07
> git bisect good 524123a70761110c5cf3ccc5f52f6d4da071b959
> # bad: [0b703dbcee7103f07804d0a4328d1593355c4324] patman: Fix detection of git version
> git bisect bad 0b703dbcee7103f07804d0a4328d1593355c4324
> # good: [63b85adcecdd019f049cbbebf10119cea45d3645] imx: ventana: set dynamic env var for flash layout
> git bisect good 63b85adcecdd019f049cbbebf10119cea45d3645
> # good: [63b85adcecdd019f049cbbebf10119cea45d3645] imx: ventana: set dynamic env var for flash layout
> git bisect good 63b85adcecdd019f049cbbebf10119cea45d3645
> # good: [04b43f32731c1171877541050bb3f2bfeb100e3d] tools/genboardscfg.py: ignore defconfigs starting with a dot
> git bisect good 04b43f32731c1171877541050bb3f2bfeb100e3d
> # bad: [6defdc0b5552ab1af4a66a8abac8196cbb6b9e15] Merge branch 'master' of git://git.denx.de/u-boot-ti
> git bisect bad 6defdc0b5552ab1af4a66a8abac8196cbb6b9e15
> # good: [6af857c50df4e62ec08e51ad73c96f63f1480386] Merge branch 'master' of http://git.denx.de/u-boot-sunxi
> git bisect good 6af857c50df4e62ec08e51ad73c96f63f1480386
> # good: [7f14fb20f895016fb38d30ce71aeb4d441b5bcb8] Merge branch 'zynq' of git://www.denx.de/git/u-boot-microblaze
> git bisect good 7f14fb20f895016fb38d30ce71aeb4d441b5bcb8
> # bad: [61f66fd5a81b97478e9d14326c1059baa6626680] keystone2: use EFUSE_BOOTROM information to configure PLLs
> git bisect bad 61f66fd5a81b97478e9d14326c1059baa6626680
> # bad: [fea9543f1bd1d068a372ef378f624941c25989a8] board/ti/am335x: update configs for parallel NAND
> git bisect bad fea9543f1bd1d068a372ef378f624941c25989a8
> # good: [e017fd61c5a89e32db682d94d8d669df1709edbb] tseries: Set CONFIG_ENV_IS_NOWHERE for SPL+NAND
> git bisect good e017fd61c5a89e32db682d94d8d669df1709edbb
> # bad: [83e359adf9f578a58f20daf2e4425a754defac7b] am335x_evm: Enable CONFIG_SPL_ENV_SUPPORT on EMMC_BOOT
> git bisect bad 83e359adf9f578a58f20daf2e4425a754defac7b
> # good: [00e385325fce36fa13d48091d73b1b3428394b6b] common/Makefile: Consolidate SPL ENV options, correct inclusion
> git bisect good 00e385325fce36fa13d48091d73b1b3428394b6b
> # first bad commit: [83e359adf9f578a58f20daf2e4425a754defac7b] am335x_evm: Enable CONFIG_SPL_ENV_SUPPORT on EMMC_BOOT
> 
> Revert that commit also makes it work, btw.
> 
> On a further dig into this, it looks like when enabling
> CONFIG_SPL_ENV_SUPPORT, somehow MMC numbering changes and u-boot ends up
> trying to read environment from a non-formatted EMMC.

forgot to mention, this is all on BBB and affects only am335x-based
boards, of course.

-- 
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140909/2ab8787b/attachment.pgp>

  reply	other threads:[~2014-09-09 17:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-09 17:09 [U-Boot] commit 83e359adf9f578a58f20daf2e4425a754defac7b breaks mmc Felipe Balbi
2014-09-09 17:27 ` Felipe Balbi [this message]
2014-09-10 14:50   ` Peter A. Bigot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140909172754.GS6151@saruman.home \
    --to=balbi@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.