From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolin Chen Subject: Re: [PATCH V1] ASoC: fsl_ssi: refine ipg clock usage in this module Date: Tue, 9 Sep 2014 11:41:31 -0700 Message-ID: <20140909184130.GB6944@Asurada> References: <20140909112750.GS2601@sirena.org.uk> <20140909180309.GA6784@Asurada> <20140909181516.GI2601@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20140909181516.GI2601@sirena.org.uk> Sender: linux-kernel-owner@vger.kernel.org To: Mark Brown Cc: Shengjiu Wang , timur@tabi.org, Li.Xiubo@freescale.com, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.de, alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org On Tue, Sep 09, 2014 at 07:15:16PM +0100, Mark Brown wrote: > On Tue, Sep 09, 2014 at 11:03:10AM -0700, Nicolin Chen wrote: > > On Tue, Sep 09, 2014 at 12:27:50PM +0100, Mark Brown wrote: > > > On Tue, Sep 09, 2014 at 05:18:07PM +0800, Shengjiu Wang wrote: > > > > - ssi_private->clk = devm_clk_get(&pdev->dev, NULL); > > > > + ssi_private->clk = devm_clk_get(&pdev->dev, "ipg"); > > > > Why is this change being made? It wasn't mentioned in the commit log > > > and doesn't seem relevant to moving where the enable and disable are > > > done which is what the patch is supposed to be doing... > > > I think Shengjiu is trying to keep the clock disabled while SSI's idle. > > The current driver enables ipg clock anyway even if there's no stream > > running. > > > Apparently, these should be put into the comment log. > > I got that bit. However as well as changing where the enable and > disable take place this is also changing from requesting a clock with a > NULL to requesting one called "ipg". Understood. Making one patch do one single change is the rule we should always follow. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-x233.google.com (mail-pa0-x233.google.com [IPv6:2607:f8b0:400e:c03::233]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4BF941A001C for ; Wed, 10 Sep 2014 04:41:45 +1000 (EST) Received: by mail-pa0-f51.google.com with SMTP id kx10so5959571pab.10 for ; Tue, 09 Sep 2014 11:41:42 -0700 (PDT) Date: Tue, 9 Sep 2014 11:41:31 -0700 From: Nicolin Chen To: Mark Brown Subject: Re: [PATCH V1] ASoC: fsl_ssi: refine ipg clock usage in this module Message-ID: <20140909184130.GB6944@Asurada> References: <20140909112750.GS2601@sirena.org.uk> <20140909180309.GA6784@Asurada> <20140909181516.GI2601@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20140909181516.GI2601@sirena.org.uk> Cc: Shengjiu Wang , alsa-devel@alsa-project.org, lgirdwood@gmail.com, tiwai@suse.de, linux-kernel@vger.kernel.org, timur@tabi.org, perex@perex.cz, Li.Xiubo@freescale.com, linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, Sep 09, 2014 at 07:15:16PM +0100, Mark Brown wrote: > On Tue, Sep 09, 2014 at 11:03:10AM -0700, Nicolin Chen wrote: > > On Tue, Sep 09, 2014 at 12:27:50PM +0100, Mark Brown wrote: > > > On Tue, Sep 09, 2014 at 05:18:07PM +0800, Shengjiu Wang wrote: > > > > - ssi_private->clk = devm_clk_get(&pdev->dev, NULL); > > > > + ssi_private->clk = devm_clk_get(&pdev->dev, "ipg"); > > > > Why is this change being made? It wasn't mentioned in the commit log > > > and doesn't seem relevant to moving where the enable and disable are > > > done which is what the patch is supposed to be doing... > > > I think Shengjiu is trying to keep the clock disabled while SSI's idle. > > The current driver enables ipg clock anyway even if there's no stream > > running. > > > Apparently, these should be put into the comment log. > > I got that bit. However as well as changing where the enable and > disable take place this is also changing from requesting a clock with a > NULL to requesting one called "ipg". Understood. Making one patch do one single change is the rule we should always follow.