From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Cc: Chris Zankel <chris@zankel.net>,
"Max Filippov linux-xtensa @ linux-xtensa . org"
<jcmvbkbc@gmail.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH 2/2] xtensa/uapi: Add definition of TIOC[SG]RS485
Date: Tue, 9 Sep 2014 12:18:24 -0700 [thread overview]
Message-ID: <20140909191824.GB7467@kroah.com> (raw)
In-Reply-To: <1410240056-22786-1-git-send-email-ricardo.ribalda@gmail.com>
On Tue, Sep 09, 2014 at 07:20:56AM +0200, Ricardo Ribalda Delgado wrote:
> Commit: e676253b19b2d269cccf67fdb1592120a0cd0676 [3/21] serial/8250: Add
> support for RS485 IOCTLs, adds support for RS485 ioctls for 825_core on
> all the archs. Unfortunaltely the definition of TIOCSRS485 and
> TIOCGRS485 was missing on the ioctls.h file
>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
> ---
> arch/xtensa/include/uapi/asm/ioctls.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/xtensa/include/uapi/asm/ioctls.h b/arch/xtensa/include/uapi/asm/ioctls.h
> index a47909f..accda82 100644
> --- a/arch/xtensa/include/uapi/asm/ioctls.h
> +++ b/arch/xtensa/include/uapi/asm/ioctls.h
> @@ -95,6 +95,8 @@
> #define TCSETS2 _IOW('T', 43, struct termios2)
> #define TCSETSW2 _IOW('T', 44, struct termios2)
> #define TCSETSF2 _IOW('T', 45, struct termios2)
> +#define TIOCGRS485 0x542E
> +#define TIOCSRS485 0x542F
Like your patches for other arches, please use a _IOW() macro here, not a "number".
thanks,
greg k-h
next prev parent reply other threads:[~2014-09-09 19:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 5:20 [PATCH 2/2] xtensa/uapi: Add definition of TIOC[SG]RS485 Ricardo Ribalda Delgado
2014-09-09 15:24 ` Max Filippov
2014-09-09 17:32 ` Ricardo Ribalda Delgado
2014-09-09 17:40 ` Chris Zankel
2014-09-09 19:18 ` Greg Kroah-Hartman [this message]
2014-09-09 19:40 ` Ricardo Ribalda Delgado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140909191824.GB7467@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=chris@zankel.net \
--cc=jcmvbkbc@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=ricardo.ribalda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.