From: mturquette@linaro.org (Mike Turquette)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: efm32: fix build warning
Date: Tue, 09 Sep 2014 13:52:52 -0700 [thread overview]
Message-ID: <20140909205252.19023.35880@quantum> (raw)
In-Reply-To: <34912135.k5JMtvLE1Q@wuerfel>
Quoting Arnd Bergmann (2014-09-08 11:18:57)
> On Monday 08 September 2014 19:48:05 Uwe Kleine-K?nig wrote:
> > On Mon, Sep 08, 2014 at 05:19:40PM +0200, Arnd Bergmann wrote:
> > > The normal prototype for of clk init functions is to return void,
> > > while efm32gg_cmu_init return an int, resulting in this harmless
> > > build warning:
> > >
> > > drivers/clk/clk-efm32gg.c:81:189: warning: comparison of distinct pointer types lacks a cast [enabled by default]
> > > CLK_OF_DECLARE(efm32ggcmu, "efm32gg,cmu", efm32gg_cmu_init);
> > >
> > > This changes the return type to avoid the warning.
> > >
> > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > I already sent the exact same patch some time ago, even the sha1 sums in
> > the diff match.
> >
> > Subject: [PATCH] clk/efm32gg: fix dt init prototype
> > Message-Id: <1406558301-17866-1-git-send-email-u.kleine-koenig@pengutronix.de>
> > Date: Mon, 28 Jul 2014 16:38:21 +0200
> >
>
> Ok, good to see that we came to the same conclusion.
>
> Mike, could you please try to get Uwe's patch into 3.17?
Done. Added your reviewed-by tag as well.
Regards,
Mike
>
> Arnd
prev parent reply other threads:[~2014-09-09 20:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-08 15:19 [PATCH] clk: efm32: fix build warning Arnd Bergmann
2014-09-08 17:48 ` Uwe Kleine-König
2014-09-08 18:18 ` Arnd Bergmann
2014-09-09 20:52 ` Mike Turquette [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140909205252.19023.35880@quantum \
--to=mturquette@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.