From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Joe Perches <joe@perches.com>
Cc: Andy Whitcroft <apw@canonical.com>,
linux-kernel@vger.kernel.org, kernel@pengutronix.de,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH] checkpatch: struct of_device_id should usually be const
Date: Wed, 10 Sep 2014 09:29:35 +0200 [thread overview]
Message-ID: <20140910072935.GA3755@pengutronix.de> (raw)
In-Reply-To: <1410333797.24028.29.camel@joe-AO725>
On Wed, Sep 10, 2014 at 12:23:17AM -0700, Joe Perches wrote:
> On Wed, 2014-09-10 at 09:15 +0200, Uwe Kleine-König wrote:
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> []
> > @@ -4941,6 +4941,7 @@ sub process {
> > mtrr_ops|
> > neigh_ops|
> > nlmsvc_binding|
> > + of_device_id|
> > pci_raw_ops|
> > pipe_buf_operations|
> > platform_hibernation_ops|
>
> Fine by me, there are ~1200 or so const uses.
>
> There are also ~350 of these that are not const.
>
> Are most all of those supposed to be const?
Yeah, I'm working on a patch series to fix most of these. I thought I
sent out the checkpatch patch first to slow down the occurences to fix.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
prev parent reply other threads:[~2014-09-10 7:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 7:15 [PATCH] checkpatch: struct of_device_id should usually be const Uwe Kleine-König
[not found] ` <1410333346-29062-1-git-send-email-u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2014-09-10 7:23 ` Joe Perches
2014-09-10 7:23 ` Joe Perches
2014-09-10 7:29 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140910072935.GA3755@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=apw@canonical.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=joe@perches.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.