From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 10 Sep 2014 15:33:41 +0200 From: Linus =?utf-8?Q?L=C3=BCssing?= Message-ID: <20140910133341.GI7058@odroid> References: <20140324094107.2cfbf103@nehalam.linuxnetplumber.net> <20140325125231.GW6008@Linus-Debian> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20140325125231.GW6008@Linus-Debian> Subject: Re: [Bridge] Multicast packets being lost (3.10 stable) List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: netdev@vger.kernel.org Cc: openwrt-devel@lists.openwrt.org, Greg Kroah-Hartman , bridge@lists.linux-foundation.org, David Miller , Stephen Hemminger I just got a complaint about bridges, multicast and a 3.10 kernel again. Seems like nobody had any objections about queueing these two patches for stable ( 2)+3) )? Also I'm still missing some more fixes in the stable branches. Especially 5), 6) and 7) are of high priority (next to 2) and 3) ) in my opinion as otherwise IPv6 in general could be broken for people using 3.12 or 3.13 (as 3.12 contains a patch which activates multicast snooping for link-local addresses, too: 3c3769e63). Here is a more ordered list of patches I'd suggest to be queued for stable: 1) bridge: fix switched interval for MLD Query types -> 32de868cb (present since 3.10) 2) bridge: disable snooping if there is no querier -> b00589af3 (present since 3.11) 3) bridge: don't try to update timers in case of broken MLD queries -> 248ba8ec0 (present since 3.11) 4) Revert "bridge: only expire the mdb entry when query is received" -> 454594f3b (present since 3.12) 5) bridge: multicast: add sanity check for query source addresses -> 6565b9eee (present since 3.14) 6) bridge: multicast: add sanity check for general query destination -> 9ed973cc4 (present since 3.14) 7) bridge: multicast: enable snooping on general queries only -> 20a599bec (present since 3.14) Let me know what you'd think about that or if there's any trouble applying them to older kernels. Cheers, Linus On Tue, Mar 25, 2014 at 02:06:07PM +0100, Linus Lüssing wrote: > That commit is supposed to be a fix and seems to be a easily > cherry-pickable on top of 3.10. So I think it's suitable for > stable > > There are two follow-up commit for this particular patch that I'm aware > of: "bridge: separate querier and query timer into IGMP/IPv4 > and MLD/IPv6 ones" (cc0fdd80). That's just an optimization > and can be ignored for stable. > > The second one is "bridge: don't try to update timers in case of > broken MLD queries" (248ba8ec0). Which is a direct fix for > b00589af3 and should therefore go into stable, too, if b00589af3 > goes into stable. > > Cheers, Linus > > > On Mon, Mar 24, 2014 at 09:41:07AM -0700, Stephen Hemminger wrote: > > We are seeing multicast snooping related issues. > > Is there some reason this commit never went into stable (3.10) > > > > commit b00589af3b04736376f24625ab0b394642e89e29 > > Author: Linus Lüssing > > Date: Thu Aug 1 01:06:20 2013 +0200 > > > > bridge: disable snooping if there is no querier > > > > If there is no querier on a link then we won't get periodic reports and > > therefore won't be able to learn about multicast listeners behind ports, > > potentially leading to lost multicast packets, especially for multicast > > listeners that joined before the creation of the bridge. > > > > These lost multicast packets can appear since c5c23260594 > > ("bridge: Add multicast_querier toggle and disable queries by default") > > in particular. > > > > With this patch we are flooding multicast packets if our querier is > > disabled and if we didn't detect any other querier. > > > > A grace period of the Maximum Response Delay of the querier is added to > > give multicast responses enough time to arrive and to be learned from > > before disabling the flooding behaviour again. > > > > Signed-off-by: Linus Lüssing > > Signed-off-by: David S. Miller From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus =?utf-8?Q?L=C3=BCssing?= Subject: Re: Multicast packets being lost (3.10 stable) Date: Wed, 10 Sep 2014 15:33:41 +0200 Message-ID: <20140910133341.GI7058@odroid> References: <20140324094107.2cfbf103@nehalam.linuxnetplumber.net> <20140325125231.GW6008@Linus-Debian> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: openwrt-devel@lists.openwrt.org, Greg Kroah-Hartman , bridge@lists.linux-foundation.org, David Miller , Stephen Hemminger To: netdev@vger.kernel.org Return-path: Content-Disposition: inline In-Reply-To: <20140325125231.GW6008@Linus-Debian> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openwrt-devel-bounces@lists.openwrt.org Sender: "openwrt-devel" List-Id: netdev.vger.kernel.org SSBqdXN0IGdvdCBhIGNvbXBsYWludCBhYm91dCBicmlkZ2VzLCBtdWx0aWNhc3QgYW5kIGEKMy4x MCBrZXJuZWwgYWdhaW4uIFNlZW1zIGxpa2Ugbm9ib2R5IGhhZCBhbnkgb2JqZWN0aW9ucyBhYm91 dApxdWV1ZWluZyB0aGVzZSB0d28gcGF0Y2hlcyBmb3Igc3RhYmxlICggMikrMykgKT8KCkFsc28g SSdtIHN0aWxsIG1pc3Npbmcgc29tZSBtb3JlIGZpeGVzIGluIHRoZSBzdGFibGUgYnJhbmNoZXMu CkVzcGVjaWFsbHkgNSksIDYpIGFuZCA3KSBhcmUgb2YgaGlnaCBwcmlvcml0eSAobmV4dCB0byAy KSBhbmQgMykgKQppbiBteSBvcGluaW9uIGFzIG90aGVyd2lzZSBJUHY2IGluIGdlbmVyYWwgY291 bGQgYmUgYnJva2VuIGZvciBwZW9wbGUKdXNpbmcgMy4xMiBvciAzLjEzIChhcyAzLjEyIGNvbnRh aW5zIGEgcGF0Y2ggd2hpY2ggYWN0aXZhdGVzCm11bHRpY2FzdCBzbm9vcGluZyBmb3IgbGluay1s b2NhbCBhZGRyZXNzZXMsIHRvbzogM2MzNzY5ZTYzKS4KCkhlcmUgaXMgYSBtb3JlIG9yZGVyZWQg bGlzdCBvZiBwYXRjaGVzIEknZCBzdWdnZXN0IHRvIGJlIHF1ZXVlZCBmb3IKc3RhYmxlOgoKMSkg YnJpZGdlOiBmaXggc3dpdGNoZWQgaW50ZXJ2YWwgZm9yIE1MRCBRdWVyeSB0eXBlcwogICAtPuKA rzMyZGU4NjhjYiAocHJlc2VudCBzaW5jZSAzLjEwKQoyKSBicmlkZ2U6IGRpc2FibGUgc25vb3Bp bmcgaWYgdGhlcmUgaXMgbm8gcXVlcmllcgogICAtPuKAr2IwMDU4OWFmMyAocHJlc2VudCBzaW5j ZSAzLjExKQozKSBicmlkZ2U6IGRvbid0IHRyeSB0byB1cGRhdGUgdGltZXJzIGluIGNhc2Ugb2Yg YnJva2VuIE1MRCBxdWVyaWVzCiAgIC0+IDI0OGJhOGVjMCAocHJlc2VudCBzaW5jZSAzLjExKQo0 KSBSZXZlcnQgImJyaWRnZTogb25seSBleHBpcmUgdGhlIG1kYiBlbnRyeSB3aGVuIHF1ZXJ5IGlz IHJlY2VpdmVkIgogICAtPuKArzQ1NDU5NGYzYiAocHJlc2VudCBzaW5jZSAzLjEyKQo1KSBicmlk Z2U6IG11bHRpY2FzdDogYWRkIHNhbml0eSBjaGVjayBmb3IgcXVlcnkgc291cmNlIGFkZHJlc3Nl cwogICAtPuKArzY1NjViOWVlZSAocHJlc2VudCBzaW5jZSAzLjE0KQo2KSBicmlkZ2U6IG11bHRp Y2FzdDogYWRkIHNhbml0eSBjaGVjayBmb3IgZ2VuZXJhbCBxdWVyeSBkZXN0aW5hdGlvbgogICAt PuKArzllZDk3M2NjNCAocHJlc2VudCBzaW5jZSAzLjE0KQo3KSBicmlkZ2U6IG11bHRpY2FzdDog ZW5hYmxlIHNub29waW5nIG9uIGdlbmVyYWwgcXVlcmllcyBvbmx5CiAgIC0+4oCvMjBhNTk5YmVj IChwcmVzZW50IHNpbmNlIDMuMTQpCgpMZXQgbWUga25vdyB3aGF0IHlvdSdkIHRoaW5rIGFib3V0 IHRoYXQgb3IgaWYgdGhlcmUncyBhbnkgdHJvdWJsZQphcHBseWluZyB0aGVtIHRvIG9sZGVyIGtl cm5lbHMuCgpDaGVlcnMsIExpbnVzCgoKT24gVHVlLCBNYXIgMjUsIDIwMTQgYXQgMDI6MDY6MDdQ TSArMDEwMCwgTGludXMgTMO8c3Npbmcgd3JvdGU6Cj4gVGhhdCBjb21taXQgaXMgc3VwcG9zZWQg dG8gYmUgYSBmaXggYW5kIHNlZW1zIHRvIGJlIGEgZWFzaWx5Cj4gY2hlcnJ5LXBpY2thYmxlIG9u IHRvcCBvZiAzLjEwLiBTbyBJIHRoaW5rIGl0J3Mgc3VpdGFibGUgZm9yCj4gc3RhYmxlCj4gCj4g VGhlcmUgYXJlIHR3byBmb2xsb3ctdXAgY29tbWl0IGZvciB0aGlzIHBhcnRpY3VsYXIgcGF0Y2gg dGhhdCBJJ20gYXdhcmUKPiBvZjogImJyaWRnZTogc2VwYXJhdGUgcXVlcmllciBhbmQgcXVlcnkg dGltZXIgaW50byBJR01QL0lQdjQKPiBhbmQgTUxEL0lQdjYgb25lcyIgKGNjMGZkZDgwKS4gVGhh dCdzIGp1c3QgYW4gb3B0aW1pemF0aW9uCj4gYW5kIGNhbiBiZSBpZ25vcmVkIGZvciBzdGFibGUu Cj4gCj4gVGhlIHNlY29uZCBvbmUgaXMgImJyaWRnZTogZG9uJ3QgdHJ5IHRvIHVwZGF0ZSB0aW1l cnMgaW4gY2FzZSBvZgo+IGJyb2tlbiBNTEQgcXVlcmllcyIgKDI0OGJhOGVjMCkuIFdoaWNoIGlz IGEgZGlyZWN0IGZpeCBmb3IKPiBiMDA1ODlhZjMgYW5kIHNob3VsZCB0aGVyZWZvcmUgZ28gaW50 byBzdGFibGUsIHRvbywgaWYgYjAwNTg5YWYzCj4gZ29lcyBpbnRvIHN0YWJsZS4KPiAKPiBDaGVl cnMsIExpbnVzCj4gCj4gCj4gT24gTW9uLCBNYXIgMjQsIDIwMTQgYXQgMDk6NDE6MDdBTSAtMDcw MCwgU3RlcGhlbiBIZW1taW5nZXIgd3JvdGU6Cj4gPiBXZSBhcmUgc2VlaW5nIG11bHRpY2FzdCBz bm9vcGluZyByZWxhdGVkIGlzc3Vlcy4KPiA+IElzIHRoZXJlIHNvbWUgcmVhc29uIHRoaXMgY29t bWl0IG5ldmVyIHdlbnQgaW50byBzdGFibGUgKDMuMTApCj4gPiAKPiA+IGNvbW1pdCBiMDA1ODlh ZjNiMDQ3MzYzNzZmMjQ2MjVhYjBiMzk0NjQyZTg5ZTI5Cj4gPiBBdXRob3I6IExpbnVzIEzDvHNz aW5nIDxsaW51cy5sdWVzc2luZ0B3ZWIuZGU+Cj4gPiBEYXRlOiAgIFRodSBBdWcgMSAwMTowNjoy MCAyMDEzICswMjAwCj4gPiAKPiA+ICAgICBicmlkZ2U6IGRpc2FibGUgc25vb3BpbmcgaWYgdGhl cmUgaXMgbm8gcXVlcmllcgo+ID4gICAgIAo+ID4gICAgIElmIHRoZXJlIGlzIG5vIHF1ZXJpZXIg b24gYSBsaW5rIHRoZW4gd2Ugd29uJ3QgZ2V0IHBlcmlvZGljIHJlcG9ydHMgYW5kCj4gPiAgICAg dGhlcmVmb3JlIHdvbid0IGJlIGFibGUgdG8gbGVhcm4gYWJvdXQgbXVsdGljYXN0IGxpc3RlbmVy cyBiZWhpbmQgcG9ydHMsCj4gPiAgICAgcG90ZW50aWFsbHkgbGVhZGluZyB0byBsb3N0IG11bHRp Y2FzdCBwYWNrZXRzLCBlc3BlY2lhbGx5IGZvciBtdWx0aWNhc3QKPiA+ICAgICBsaXN0ZW5lcnMg dGhhdCBqb2luZWQgYmVmb3JlIHRoZSBjcmVhdGlvbiBvZiB0aGUgYnJpZGdlLgo+ID4gICAgIAo+ ID4gICAgIFRoZXNlIGxvc3QgbXVsdGljYXN0IHBhY2tldHMgY2FuIGFwcGVhciBzaW5jZSBjNWMy MzI2MDU5NAo+ID4gICAgICgiYnJpZGdlOiBBZGQgbXVsdGljYXN0X3F1ZXJpZXIgdG9nZ2xlIGFu ZCBkaXNhYmxlIHF1ZXJpZXMgYnkgZGVmYXVsdCIpCj4gPiAgICAgaW4gcGFydGljdWxhci4KPiA+ ICAgICAKPiA+ICAgICBXaXRoIHRoaXMgcGF0Y2ggd2UgYXJlIGZsb29kaW5nIG11bHRpY2FzdCBw YWNrZXRzIGlmIG91ciBxdWVyaWVyIGlzCj4gPiAgICAgZGlzYWJsZWQgYW5kIGlmIHdlIGRpZG4n dCBkZXRlY3QgYW55IG90aGVyIHF1ZXJpZXIuCj4gPiAgICAgCj4gPiAgICAgQSBncmFjZSBwZXJp b2Qgb2YgdGhlIE1heGltdW0gUmVzcG9uc2UgRGVsYXkgb2YgdGhlIHF1ZXJpZXIgaXMgYWRkZWQg dG8KPiA+ICAgICBnaXZlIG11bHRpY2FzdCByZXNwb25zZXMgZW5vdWdoIHRpbWUgdG8gYXJyaXZl IGFuZCB0byBiZSBsZWFybmVkIGZyb20KPiA+ICAgICBiZWZvcmUgZGlzYWJsaW5nIHRoZSBmbG9v ZGluZyBiZWhhdmlvdXIgYWdhaW4uCj4gPiAgICAgCj4gPiAgICAgU2lnbmVkLW9mZi1ieTogTGlu dXMgTMO8c3NpbmcgPGxpbnVzLmx1ZXNzaW5nQHdlYi5kZT4KPiA+ICAgICBTaWduZWQtb2ZmLWJ5 OiBEYXZpZCBTLiBNaWxsZXIgPGRhdmVtQGRhdmVtbG9mdC5uZXQ+Cl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCm9wZW53cnQtZGV2ZWwgbWFpbGluZyBsaXN0 Cm9wZW53cnQtZGV2ZWxAbGlzdHMub3BlbndydC5vcmcKaHR0cHM6Ly9saXN0cy5vcGVud3J0Lm9y Zy9jZ2ktYmluL21haWxtYW4vbGlzdGluZm8vb3BlbndydC1kZXZlbAo=