From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sudip Mukherjee Subject: Re: [PATCH] sound: aoa: printk replacement Date: Wed, 10 Sep 2014 20:02:04 +0530 Message-ID: <20140910143204.GA30695@sudip-PC> References: <1410357107-29933-1-git-send-email-sudipm.mukherjee@gmail.com> <1410357424.2761.5.camel@jlt4.sipsolutions.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pd0-f175.google.com (mail-pd0-f175.google.com [209.85.192.175]) by alsa0.perex.cz (Postfix) with ESMTP id D226E262606 for ; Wed, 10 Sep 2014 16:32:16 +0200 (CEST) Received: by mail-pd0-f175.google.com with SMTP id z10so11223730pdj.6 for ; Wed, 10 Sep 2014 07:32:15 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1410357424.2761.5.camel@jlt4.sipsolutions.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Johannes Berg Cc: Takashi Iwai , alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org On Wed, Sep 10, 2014 at 03:57:04PM +0200, Johannes Berg wrote: > On Wed, 2014-09-10 at 19:21 +0530, Sudip Mukherjee wrote: > > as pr_* macros are more preffered over printk, so printk replaced > > with corresponding pr_* macros. > > Are you simply running checkpatch on every file and decided to do > something about it? :) > i am running checkpatch on the patch generated. if i am doing checkpatch cleanups then that i do it only in the staging. only exception : printk .. :) > I'll let Takashi decide whether to take this or not as I no longer care > about this code, but IMHO this changes is completely pointless since you > don't also clean up the code to have a common prefix with #define pr_fmt > and then clean up the callers etc. > i mentioned in the comment that in a future patch we can have pr_fmt, it was not done in this patch since the changes for this patch is generated by a script and not manually. if Takashi accepts this then the next patch will have pr_fmt. thanks sudip > There's a reason pr_* is preferred, but random code changes like this > aren't it, I think. > > johannes > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-x22f.google.com (mail-pa0-x22f.google.com [IPv6:2607:f8b0:400e:c03::22f]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 898E41A0003 for ; Thu, 11 Sep 2014 00:32:17 +1000 (EST) Received: by mail-pa0-f47.google.com with SMTP id ey11so9422671pad.6 for ; Wed, 10 Sep 2014 07:32:15 -0700 (PDT) Date: Wed, 10 Sep 2014 20:02:04 +0530 From: Sudip Mukherjee To: Johannes Berg Subject: Re: [PATCH] sound: aoa: printk replacement Message-ID: <20140910143204.GA30695@sudip-PC> References: <1410357107-29933-1-git-send-email-sudipm.mukherjee@gmail.com> <1410357424.2761.5.camel@jlt4.sipsolutions.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1410357424.2761.5.camel@jlt4.sipsolutions.net> Cc: Takashi Iwai , alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Jaroslav Kysela List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Sep 10, 2014 at 03:57:04PM +0200, Johannes Berg wrote: > On Wed, 2014-09-10 at 19:21 +0530, Sudip Mukherjee wrote: > > as pr_* macros are more preffered over printk, so printk replaced > > with corresponding pr_* macros. > > Are you simply running checkpatch on every file and decided to do > something about it? :) > i am running checkpatch on the patch generated. if i am doing checkpatch cleanups then that i do it only in the staging. only exception : printk .. :) > I'll let Takashi decide whether to take this or not as I no longer care > about this code, but IMHO this changes is completely pointless since you > don't also clean up the code to have a common prefix with #define pr_fmt > and then clean up the callers etc. > i mentioned in the comment that in a future patch we can have pr_fmt, it was not done in this patch since the changes for this patch is generated by a script and not manually. if Takashi accepts this then the next patch will have pr_fmt. thanks sudip > There's a reason pr_* is preferred, but random code changes like this > aren't it, I think. > > johannes > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753112AbaIJOcR (ORCPT ); Wed, 10 Sep 2014 10:32:17 -0400 Received: from mail-pa0-f53.google.com ([209.85.220.53]:63426 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752711AbaIJOcP (ORCPT ); Wed, 10 Sep 2014 10:32:15 -0400 Date: Wed, 10 Sep 2014 20:02:04 +0530 From: Sudip Mukherjee To: Johannes Berg Cc: Jaroslav Kysela , Takashi Iwai , linuxppc-dev@lists.ozlabs.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sound: aoa: printk replacement Message-ID: <20140910143204.GA30695@sudip-PC> References: <1410357107-29933-1-git-send-email-sudipm.mukherjee@gmail.com> <1410357424.2761.5.camel@jlt4.sipsolutions.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1410357424.2761.5.camel@jlt4.sipsolutions.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 10, 2014 at 03:57:04PM +0200, Johannes Berg wrote: > On Wed, 2014-09-10 at 19:21 +0530, Sudip Mukherjee wrote: > > as pr_* macros are more preffered over printk, so printk replaced > > with corresponding pr_* macros. > > Are you simply running checkpatch on every file and decided to do > something about it? :) > i am running checkpatch on the patch generated. if i am doing checkpatch cleanups then that i do it only in the staging. only exception : printk .. :) > I'll let Takashi decide whether to take this or not as I no longer care > about this code, but IMHO this changes is completely pointless since you > don't also clean up the code to have a common prefix with #define pr_fmt > and then clean up the callers etc. > i mentioned in the comment that in a future patch we can have pr_fmt, it was not done in this patch since the changes for this patch is generated by a script and not manually. if Takashi accepts this then the next patch will have pr_fmt. thanks sudip > There's a reason pr_* is preferred, but random code changes like this > aren't it, I think. > > johannes >