From: Andi Kleen <andi@firstfloor.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Andi Kleen <andi@firstfloor.org>,
linux-kernel@vger.kernel.org, mingo@kernel.org,
eranian@google.com, tglx@linutronix.de,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] perf, x86: Fall back to vmalloc for BTS buffer allocation
Date: Wed, 10 Sep 2014 16:40:12 +0200 [thread overview]
Message-ID: <20140910144012.GI4120@two.firstfloor.org> (raw)
In-Reply-To: <20140910075722.GL6758@twins.programming.kicks-ass.net>
> We did this once, and that blew up big time.
>
> Even now, vmalloc_fault() has a very explicit:
>
> WARN_ON_ONCE(in_nmi());
>
> So this isn't going to happen until you fix that.
Good point.
We just need to call vmalloc_sync_all at allocation time,
no need to change vmalloc_fault.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2014-09-10 14:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 0:03 [PATCH] perf, x86: Fall back to vmalloc for BTS buffer allocation Andi Kleen
2014-09-10 7:57 ` Peter Zijlstra
2014-09-10 14:40 ` Andi Kleen [this message]
2014-09-10 16:35 ` Peter Zijlstra
2014-09-10 16:58 ` Peter Zijlstra
2014-09-10 18:27 ` Andi Kleen
2014-09-10 18:52 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140910144012.GI4120@two.firstfloor.org \
--to=andi@firstfloor.org \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.