From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Keir Fraser <keir@xen.org>,
Ian Campbell <ian.campbell@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
Don Slutz <dslutz@verizon.com>,
xen-devel@lists.xen.org
Subject: Re: [RFC][PATCH v1 2/2] Adjust checkpatch.pl to xen CODING_STYLE
Date: Wed, 10 Sep 2014 12:11:19 -0400 [thread overview]
Message-ID: <20140910161119.GK12893@laptop.dumpdata.com> (raw)
In-Reply-To: <54106B360200007800033470@mail.emea.novell.com>
On Wed, Sep 10, 2014 at 02:16:06PM +0100, Jan Beulich wrote:
> >>> On 10.09.14 at 14:34, <dslutz@verizon.com> wrote:
> > Signed-off-by: Don Slutz <dslutz@verizon.com>
>
> At least my Perl knowledge isn't good enough to easily tell what you're
> changing here, i.e. in particular which of the exceptions to the general
> rules you're taking into account. It depends to a large degree however
> on whether such exceptions are being taken care of, as without that
> people may quickly drop using the script again if it generates false
> complaints.
Or fix the script. I would certainly welcome this as I have a hard time
doing 'style-guide-context-switching' from Xen and Linux (and vice-versa)
and this I hope would help me catch the obvious ones.
>
> Jan
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2014-09-10 16:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 12:34 [RFC][PATCH v1 0/2] Add scripts/checkpatch.pl Don Slutz
2014-09-10 12:34 ` [RFC][PATCH v1 1/2] Import checkpatch.pl from QEMU Don Slutz
2014-09-10 12:34 ` [RFC][PATCH v1 2/2] Adjust checkpatch.pl to xen CODING_STYLE Don Slutz
2014-09-10 13:16 ` Jan Beulich
2014-09-10 16:11 ` Konrad Rzeszutek Wilk [this message]
2014-09-10 16:09 ` [RFC][PATCH v1 0/2] Add scripts/checkpatch.pl Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140910161119.GK12893@laptop.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=JBeulich@suse.com \
--cc=dslutz@verizon.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=keir@xen.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.