From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCHv2] xen: remove DEFINE_XENBUS_DRIVER() macro Date: Wed, 10 Sep 2014 12:44:58 -0400 Message-ID: <20140910164458.GB16190@laptop.dumpdata.com> References: <1410350869-21277-1-git-send-email-david.vrabel@citrix.com> <20140910160043.GH12893@laptop.dumpdata.com> <54107B84.7070005@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XRl16-00072a-7i for xen-devel@lists.xenproject.org; Wed, 10 Sep 2014 16:45:12 +0000 Content-Disposition: inline In-Reply-To: <54107B84.7070005@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: David Vrabel Cc: xen-devel@lists.xenproject.org, Boris Ostrovsky , Jan Beulich List-Id: xen-devel@lists.xenproject.org On Wed, Sep 10, 2014 at 05:25:40PM +0100, David Vrabel wrote: > On 10/09/14 17:00, Konrad Rzeszutek Wilk wrote: > > On Wed, Sep 10, 2014 at 01:07:49PM +0100, David Vrabel wrote: > >> The DEFINE_XENBUS_DRIVER() macro looks a bit weird and causes sparse > >> errors. > > > > .. but it is also useful for downstream distros to bolt on Xen patches. > > > > Is this urgent? Could it wait until Novell/SuSE has switched over > > to using pvops and then this can go in? > > If the macro didn't cause sparse errors, I could be persuaded to wait. I presume there is a going to be more of the 'sparse errors' fixes coming? > > I do not think we should avoid fixing bugs or improving the readability > or maintainability of the code to help out someone still using > non-upstream Xen support. That is not what I am saying. I am asking whether it could wait a bit. It is not that urgent is it? Why are sparse errors suddenly so important? > > In general, the cost of maintaining non-upstream forks should not be > paid for by upstream users/developers. Of course. However the downstream forks have nice QA departments that can catch upstream bugs as they rebase. Accomodating them and at the same time nudging them towards upstream I think is a small price to pay. > > David