Re: [PATCH v2 01/10] clk: shmobile: sh73a0 common clock framework implementation

[Mike Turquette <mturquette@linaro.org>]

Quoting Laurent Pinchart (2014-09-09 15:27:27)
> Hi Mike,
> 
> On Tuesday 09 September 2014 15:19:10 Mike Turquette wrote:
> > Quoting Simon Horman (2014-09-03 23:49:24)
> > > On Wed, Sep 03, 2014 at 09:50:48AM +0200, Ulrich Hecht wrote:
> > >> On Wed, Sep 3, 2014 at 7:40 AM, Mike Turquette wrote:
> > >>> Quoting Ulrich Hecht (2014-09-02 02:12:57)
> > >>> 
> > >>>> diff --git a/drivers/clk/shmobile/Makefile
> > >>>> b/drivers/clk/shmobile/Makefile
> > >>>> index 531d4f6..0c4fd11 100644
> > >>>> --- a/drivers/clk/shmobile/Makefile
> > >>>> +++ b/drivers/clk/shmobile/Makefile
> > >>>> @@ -5,6 +5,7 @@ obj-$(CONFIG_ARCH_R8A7779)              +> > >>>> clk-r8a7779.o
> > >>>> 
> > >>>>  obj-$(CONFIG_ARCH_R8A7790)             += clk-rcar-gen2.o
> > >>>>  obj-$(CONFIG_ARCH_R8A7791)             += clk-rcar-gen2.o
> > >>>>  obj-$(CONFIG_ARCH_R8A7794)             += clk-rcar-gen2.o
> > >>>> 
> > >>>> +obj-$(CONFIG_ARCH_SH73A0)              += clk-sh73a0.o
> > >>>> 
> > >>>>  obj-$(CONFIG_ARCH_SHMOBILE_MULTI)      += clk-div6.o
> > >>>>  obj-$(CONFIG_ARCH_SHMOBILE_MULTI)      += clk-mstp.o
> > >>>>  # for emply built-in.o
> > >>> 
> > >>> So I don't have any of the CONFIG_ARCH_R8A7794 stuff in my tree, per
> > >>> this email thread [0].
> > >>> 
> > >>> Do you want the clk patches in this series to go through Simon's tree
> > >>> also?
> > >> 
> > >> That would probably work best.
> > > 
> > > Yes, I think so too.
> > > 
> > > Mike, could you provide an Ack?
> > 
> > Sure, you have my Ack for patch #1 and #8. I think #9 is still
> > unresolved. Will that be converted to a mux clock?
> 
> As the DIV6 clocks support rate modification at runtime, so we can't turn them 
> into plain mux clocks.

Nomenclature confusion ;-)

I don't actually mean to use common struct clk_mux. I mean, "support
.get_parent and .set_parent callbacks in your clock driver
implementation for DIV6 clocks".

> 
> I don't have a strong preference between static and dynamic parent selection 
> until someone provides use cases for dynamic parent selection. We need to iron 
> out the DT bindings though, and regardless of the chosen implementation.

Agreed.

Regards,
Mike

> 
> -- 
> Regards,
> 
> Laurent Pinchart
>