From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yh0-f42.google.com (mail-yh0-f42.google.com [209.85.213.42]) by kanga.kvack.org (Postfix) with ESMTP id 13AB26B007D for ; Wed, 10 Sep 2014 15:40:14 -0400 (EDT) Received: by mail-yh0-f42.google.com with SMTP id z6so4684219yhz.29 for ; Wed, 10 Sep 2014 12:40:13 -0700 (PDT) Received: from imap.thunk.org (imap.thunk.org. [2600:3c02::f03c:91ff:fe96:be03]) by mx.google.com with ESMTPS id k29si12939280yha.8.2014.09.10.12.40.13 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 10 Sep 2014 12:40:13 -0700 (PDT) Date: Wed, 10 Sep 2014 15:40:10 -0400 From: Theodore Ts'o Subject: Re: [PATCH] mm/sl[aou]b: make kfree() aware of error pointers Message-ID: <20140910194010.GE31903@thunk.org> References: <20140909162114.44b3e98cf925f125e84a8a06@linux-foundation.org> <20140910140759.GC31903@thunk.org> <20140910152104.GS6549@mwanda> <20140910155356.GT6549@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140910155356.GT6549@mwanda> Sender: owner-linux-mm@kvack.org List-ID: To: Dan Carpenter Cc: Jiri Kosina , Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , linux-kernel@vger.kernel.org, linux-mm@kvack.org On Wed, Sep 10, 2014 at 06:53:56PM +0300, Dan Carpenter wrote: > On Wed, Sep 10, 2014 at 05:28:11PM +0200, Jiri Kosina wrote: > > > > Too late for this now, yes. > > We could still introduce a __kfree_fast_path() which doesn't have > checking. Well, there certainly is precedence for that sort of thing. There is a bunch of code which uses __brelse(bh) instead of brelse(bh) when the caller is sure that bh is a valid non-NULL pointer. - Ted -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753385AbaIJTkV (ORCPT ); Wed, 10 Sep 2014 15:40:21 -0400 Received: from imap.thunk.org ([74.207.234.97]:49180 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751044AbaIJTkT (ORCPT ); Wed, 10 Sep 2014 15:40:19 -0400 Date: Wed, 10 Sep 2014 15:40:10 -0400 From: "Theodore Ts'o" To: Dan Carpenter Cc: Jiri Kosina , Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm/sl[aou]b: make kfree() aware of error pointers Message-ID: <20140910194010.GE31903@thunk.org> Mail-Followup-To: Theodore Ts'o , Dan Carpenter , Jiri Kosina , Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20140909162114.44b3e98cf925f125e84a8a06@linux-foundation.org> <20140910140759.GC31903@thunk.org> <20140910152104.GS6549@mwanda> <20140910155356.GT6549@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140910155356.GT6549@mwanda> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 10, 2014 at 06:53:56PM +0300, Dan Carpenter wrote: > On Wed, Sep 10, 2014 at 05:28:11PM +0200, Jiri Kosina wrote: > > > > Too late for this now, yes. > > We could still introduce a __kfree_fast_path() which doesn't have > checking. Well, there certainly is precedence for that sort of thing. There is a bunch of code which uses __brelse(bh) instead of brelse(bh) when the caller is sure that bh is a valid non-NULL pointer. - Ted