From: Theodore Ts'o <tytso@mit.edu>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: TR Reardon <thomas_reardon@hotmail.com>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>
Subject: Re: dumpe2fs: only print 'unused inodes' once
Date: Wed, 10 Sep 2014 17:38:43 -0400 [thread overview]
Message-ID: <20140910213843.GB15632@thunk.org> (raw)
In-Reply-To: <20140909194746.GF10351@birch.djwong.org>
On Tue, Sep 09, 2014 at 12:47:46PM -0700, Darrick J. Wong wrote:
> On Tue, Sep 09, 2014 at 03:32:56PM -0400, TR Reardon wrote:
> > just a minor nit...and I don't think fixing this harms any existing tests.
>
> Running 'make check' will tell you.
>
> This also needs a Signed-off-by.
It also might make more sense to move the checksum to after the inode
table, i.e., instead of:
Group 0: (Blocks 0-32767) [ITABLE_ZEROED]
Checksum 0xe0c6
Primary superblock at 0, Group descriptors at 1-1
Reserved GDT blocks at 2-512
Block bitmap at 513 (+513), Inode bitmap at 529 (+529)
Inode table at 545-1056 (+545)
24025 free blocks, 8181 free inodes, 2 directories, 8181 unused inodes
Free blocks: 8743-32767
Free inodes: 12-8192
how about:
Group 0: (Blocks 0-32767) [ITABLE_ZEROED]
Primary superblock at 0, Group descriptors at 1-1
Reserved GDT blocks at 2-512
Block bitmap at 513 (+513), Inode bitmap at 529 (+529)
Inode table at 545-1056 (+545), Checksum 0xe0c6
24025 free blocks, 8181 free inodes, 2 directories, 8181 unused inodes
Free blocks: 8743-32767
Free inodes: 12-8192
- Ted
>
> --D
> >
> > +Reardon
> >
> >
> > diff --git a/misc/dumpe2fs.c b/misc/dumpe2fs.c
> > index a1c5ba2..d30cf87 100644
> > --- a/misc/dumpe2fs.c
> > +++ b/misc/dumpe2fs.c
> > @@ -205,8 +205,6 @@ static void list_desc (ext2_filsys fs)
> > printf(_(" Checksum 0x%04x"), csum);
> > if (csum != exp_csum)
> > printf(_(" (EXPECTED 0x%04x)"), exp_csum);
> > - printf(_(", unused inodes %u\n"),
> > - ext2fs_bg_itable_unused(fs, i));
> > }
> > has_super = ((i==0) || super_blk);
> > if (has_super) {
> >
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-09-10 21:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 19:32 dumpe2fs: only print 'unused inodes' once TR Reardon
2014-09-09 19:47 ` Darrick J. Wong
2014-09-10 21:38 ` Theodore Ts'o [this message]
2014-09-10 21:47 ` Darrick J. Wong
2014-09-11 12:53 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140910213843.GB15632@thunk.org \
--to=tytso@mit.edu \
--cc=darrick.wong@oracle.com \
--cc=linux-ext4@vger.kernel.org \
--cc=thomas_reardon@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.