From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753409AbaIKIxJ (ORCPT <rfc822;w@1wt.eu>);
	Thu, 11 Sep 2014 04:53:09 -0400
Received: from mga01.intel.com ([192.55.52.88]:38682 "EHLO mga01.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753481AbaIKIxH (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 11 Sep 2014 04:53:07 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.04,504,1406617200"; 
   d="scan'208";a="597947748"
Date: Thu, 11 Sep 2014 11:53:03 +0300
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Jiang Liu <jiang.liu@linux.intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: Ask help about pre_init_apic_IRQ0()
Message-ID: <20140911085303.GN13406@lahna.fi.intel.com>
References: <54116106.5090904@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <54116106.5090904@linux.intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Sep 11, 2014 at 04:44:54PM +0800, Jiang Liu wrote:
> Hi Thomas,
> 
> When converting IOAPIC to hierarchy irqdomain, I ran into trouble when
> dealing with pre_init_apic_IRQ0(). Currently pre_init_apic_IRQ0() is
> only used by intel-mid platform and is called before initializing of
> IOAPIC irqdomains. That really causes headache when converting to
> hierarchy irqdomain. So could we delay
> 	io_apic_setup_irq_pin(0, 0, &attr);
>         irq_set_chip_and_handler_name(0, &ioapic_chip, handle_edge_irq,
>                                       "edge");
> to the point of "check_timer()"?
> 
> I have no MID hardware at handle so can't experiment with it. Could
> you please refer someone for help?

Andy (Cc'd) has some MID boards that he uses almost daily basis. Andy
can you help Jiang here?

> 
> /* Enable IOAPIC early just for system timer */
> void __init pre_init_apic_IRQ0(void)
> {
>         struct io_apic_irq_attr attr = { 0, 0, 0, 0 };
> 
>         printk(KERN_INFO "Early APIC setup for system timer0\n");
> #ifndef CONFIG_SMP
>         physid_set_mask_of_physid(boot_cpu_physical_apicid,
>                                          &phys_cpu_present_map);
> #endif
>         setup_local_APIC();
> 
>         io_apic_setup_irq_pin(0, 0, &attr);
>         irq_set_chip_and_handler_name(0, &ioapic_chip, handle_edge_irq,
>                                       "edge");
> }
> 
> Regards!
> Gerry