From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43888) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XS56M-0001Sp-Nr for qemu-devel@nongnu.org; Thu, 11 Sep 2014 10:12:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XS56C-0004hc-Ja for qemu-devel@nongnu.org; Thu, 11 Sep 2014 10:11:58 -0400 Received: from e31.co.us.ibm.com ([32.97.110.149]:47206) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XS56C-0004h2-Aj for qemu-devel@nongnu.org; Thu, 11 Sep 2014 10:11:48 -0400 Received: from /spool/local by e31.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 11 Sep 2014 08:11:45 -0600 Received: from b03cxnp08028.gho.boulder.ibm.com (b03cxnp08028.gho.boulder.ibm.com [9.17.130.20]) by d03dlp03.boulder.ibm.com (Postfix) with ESMTP id 295BF19D8039 for ; Thu, 11 Sep 2014 08:11:30 -0600 (MDT) Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by b03cxnp08028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id s8BEBgaS45350968 for ; Thu, 11 Sep 2014 16:11:43 +0200 Received: from d03av03.boulder.ibm.com (localhost [127.0.0.1]) by d03av03.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s8BEBfUK006418 for ; Thu, 11 Sep 2014 08:11:41 -0600 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Roth In-Reply-To: <24E144B8C0207547AD09C467A8259F755D12D7E6@lisa.maurer-it.com> References: <20140910204400.32021.10241@loki> <24E144B8C0207547AD09C467A8259F755D12D7E6@lisa.maurer-it.com> Message-ID: <20140911141140.32021.22872@loki> Date: Thu, 11 Sep 2014 09:11:40 -0500 Subject: Re: [Qemu-devel] [Qemu-stable] [ANNOUNCE] QEMU 2.1.1 Stable released List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dietmar Maurer , "qemu-devel@nongnu.org" Cc: jasowang@redhat.com, mst@redhat.com Quoting Dietmar Maurer (2014-09-11 04:55:05) > Seems that we get a crash when we live-migrate a VMs using virtio-net-pci= (vhost=3Don). > This worked in 2.1.0. Any ideas? Is this what you're seeing on the source side? qemu-system-x86_64: /home/mdroth/w/qemu3.git/hw/net/virtio-net.c:1348: virt= io_net_save: Assertion `!n->vhost_started' failed. = If so I can reproduce on both stable and current master. A bisect of master points to the following commit. 269bd822e7f5ab80048b05fb7076236ed66ffbce is the first bad commit commit 269bd822e7f5ab80048b05fb7076236ed66ffbce Author: Michael S. Tsirkin Date: Thu Sep 4 13:32:54 2014 +0300 virtio: don't call device on !vm_running = On vm stop, virtio changes vm_running state too soon, so callbacks can get envoked with vm_running =3D false; = Cc: qemu-stable@nongnu.org Cc: Jason Wang Signed-off-by: Michael S. Tsirkin Signed-off-by: Stefan Hajnoczi Any ideas Michael/Jason? This is with: qemu-system-x86_64 -enable-kvm -L build/build3-bios -M pc-i440fx-2.1 -m 512= M -kernel boot/vmlinuz-x86_64 -initrd boot/test-initramfs-x86_64.img.gz -vg= a cirrus -append seed=3D1234 -drive file=3Ddisk1.img,if=3Dvirtio,cache=3Ddi= rectsync -drive file=3Ddisk2.img,if=3Dvirtio -device virtio-net-pci,netdev= =3Dnet0 -netdev tap,id=3Dnet0,vhost=3Don,script=3D/etc/qemu-ifup -incoming = unix:/tmp/migrate.sock -monitor unix:/tmp/vm-hmp-incoming.sock,server,nowai= t -qmp unix:/tmp/vm-qmp-incoming.sock,server,nowait Since this is such a common use-case of live migration I'll likely be putti= ng out a minor 2.1.2 update once we identify the fix. I unfortunately didn't have = vhost enabled in the migration tests, which was a pretty big oversight on my part. > = > > I am pleased to announce that the QEMU v2.1.1 stable release is now ava= ilable > > at: