From: Theodore Ts'o <tytso@mit.edu>
To: Lukas Czerner <lczerner@redhat.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [2/2] ext4: Provide separate operations for sysfs feature files
Date: Thu, 11 Sep 2014 11:28:47 -0400 [thread overview]
Message-ID: <20140911152847.GA19019@thunk.org> (raw)
In-Reply-To: <1410262340-13713-2-git-send-email-lczerner@redhat.com>
On Tue, Sep 09, 2014 at 01:32:20PM +0200, Lukas Czerner wrote:
> Currently sysfs feature files uses ext4_attr_ops as the file operations
> to show/store data. However the feature files is not supposed to contain
> any data at all, the sole existence of the file means that the module
> support the feature. Moreover, none of the sysfs feature attributes
> actually register show/store functions so that would not be a problem.
>
> However if a sysfs feature attribute register a show or store function
> we might be in trouble because the kobject in this case is _not_ embedded
> in the ext4_sb_info structure as ext4_attr_show/store expect.
>
> So just to be safe, provide separate empty sysfs_ops to use in
> ext4_feat_ktype. This might safe us from potential problems in the
> future. As a bonus we can "store" something more descriptive than
> nothing in the files, so let it contain "enabled" to make it clear that
> the feature is really present in the module.
>
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
Applied, thanks.
- Ted
next prev parent reply other threads:[~2014-09-11 15:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 11:32 [PATCH 1/2] ext4: add sysfs entry showing whether the fs contains errors Lukas Czerner
2014-09-09 11:32 ` [PATCH 2/2] ext4: Provide separate operations for sysfs feature files Lukas Czerner
2014-09-11 15:28 ` Theodore Ts'o [this message]
2014-09-11 15:19 ` [PATCH 1/2] ext4: add sysfs entry showing whether the fs contains errors Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140911152847.GA19019@thunk.org \
--to=tytso@mit.edu \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.