From: Theodore Ts'o <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>, Tao Ma <tm@tao.ma>,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH 4/4] ext4: don't keep using page if inline conversion fails
Date: Thu, 11 Sep 2014 11:46:27 -0400 [thread overview]
Message-ID: <20140911154627.GC26178@thunk.org> (raw)
In-Reply-To: <20140911131753.GB30901@quack.suse.cz>
On Thu, Sep 11, 2014 at 03:17:53PM +0200, Jan Kara wrote:
> On Wed 10-09-14 17:28:45, Darrick J. Wong wrote:
> > If inline->extent conversion fails (most probably due to ENOSPC) and
> > we release the temporary page that we allocated to transfer the file
> > contents, don't keep using the page pointer after releasing the page.
> > This occasionally leads to complaints about evicting locked pages or
> > hangs when blocksize > pagesize, because it's possible for the page to
> > get reallocated elsewhere in the meantime.
> Good catch! You can add:
> Reviewed-by: Jan Kara <jack@suse.cz>
Applied, thanks.
- Ted
next prev parent reply other threads:[~2014-09-11 15:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-11 0:28 [PATCH 0/4] ext4/jbd2: misc 3.17 bugfixes Darrick J. Wong
2014-09-11 0:28 ` [PATCH 1/4] jbd2: fix journal checksum feature flag handling Darrick J. Wong
2014-09-11 15:47 ` Theodore Ts'o
2014-09-11 0:28 ` [PATCH 2/4] ext4: validate external journal superblock checksum Darrick J. Wong
2014-09-11 13:25 ` Jan Kara
2014-09-11 15:47 ` Theodore Ts'o
2014-09-11 17:11 ` Darrick J. Wong
2014-09-11 0:28 ` [PATCH 3/4] jbd2: restart replay without revokes if journal block csum fails Darrick J. Wong
2014-09-11 13:15 ` Jan Kara
2014-09-11 17:30 ` Darrick J. Wong
2014-09-11 17:43 ` Darrick J. Wong
2014-09-12 9:59 ` Jan Kara
2014-09-11 0:28 ` [PATCH 4/4] ext4: don't keep using page if inline conversion fails Darrick J. Wong
2014-09-11 13:17 ` Jan Kara
2014-09-11 15:46 ` Theodore Ts'o [this message]
2014-09-11 20:35 ` [PATCH 5/4] ext4: check EA value offset when loading Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140911154627.GC26178@thunk.org \
--to=tytso@mit.edu \
--cc=darrick.wong@oracle.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=tm@tao.ma \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.