From: "John W. Linville" <linville@tuxdriver.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>, g@tuxdriver.com
Cc: Jouni Malinen <j@w1.fi>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] hostap: proc: substitute loops by %*phN
Date: Thu, 11 Sep 2014 15:27:21 -0400 [thread overview]
Message-ID: <20140911192721.GD22872@tuxdriver.com> (raw)
In-Reply-To: <1409927416-27101-1-git-send-email-andriy.shevchenko@linux.intel.com>
Applying: hostap: proc: substitute loops by %*phN
error: patch failed: drivers/net/wireless/hostap/hostap_proc.c:184
error: drivers/net/wireless/hostap/hostap_proc.c: patch does not apply
On Fri, Sep 05, 2014 at 05:30:16PM +0300, Andy Shevchenko wrote:
> For dumping small buffers we may use %*phN specifier instead of custom
> approach..
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/net/wireless/hostap/hostap_proc.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/wireless/hostap/hostap_proc.c b/drivers/net/wireless/hostap/hostap_proc.c
> index 16a06b6..4e2a7dd9 100644
> --- a/drivers/net/wireless/hostap/hostap_proc.c
> +++ b/drivers/net/wireless/hostap/hostap_proc.c
> @@ -184,11 +184,9 @@ static int prism2_bss_list_proc_show(struct seq_file *m, void *v)
> seq_printf(m, "%*pE", bss->ssid_len, bss->ssid);
>
> seq_putc(m, '\t');
> - for (i = 0; i < bss->ssid_len; i++)
> - seq_printf(m, "%02x", bss->ssid[i]);
> + seq_printf(m, "%*phN", (int)bss->ssid_len, bss->ssid);
> seq_putc(m, '\t');
> - for (i = 0; i < bss->wpa_ie_len; i++)
> - seq_printf(m, "%02x", bss->wpa_ie[i]);
> + seq_printf(m, "%*phN", (int)bss->wpa_ie_len, bss->wpa_ie);
> seq_putc(m, '\n');
> return 0;
> }
> --
> 2.1.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2014-09-11 19:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-05 14:30 [PATCH] hostap: proc: substitute loops by %*phN Andy Shevchenko
2014-09-11 19:27 ` John W. Linville [this message]
2014-09-12 7:24 ` Andy Shevchenko
2014-09-15 19:02 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140911192721.GD22872@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=g@tuxdriver.com \
--cc=j@w1.fi \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.