From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Hartley Sweeten <HartleyS@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>,
"driverdev-devel@linuxdriverproject.org"
<driverdev-devel@linuxdriverproject.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 00/48] staging: comedi: avoid using comedi_board()
Date: Thu, 11 Sep 2014 14:37:41 -0700 [thread overview]
Message-ID: <20140911213741.GA4542@kroah.com> (raw)
In-Reply-To: <DC148C5AA1CEBA4E87973D432B1C2D8825F9872E@P3PWEX4MB008.ex4.secureserver.net>
On Thu, Sep 11, 2014 at 05:57:34PM +0000, Hartley Sweeten wrote:
> On Tuesday, September 09, 2014 3:26 AM, Ian Abbott wrote:
> > The `comedi_board` inline function takes a single parameter of type
> > `struct comedi_device *` and merely returns the value of the `board_ptr`
> > member therein. This is somewhat superfluous as the member can be
> > accessed directly.
> >
> > Replace all uses of `comedi_board(dev)` with `dev->board_ptr`.
> >
> > Note, if there are any conflicts when applying this series, they can
> > just be skipped for now and corrected later.
> >
> > A subsequent patch will remove the `comedi_board` function, once there
> > is nothing using it.
>
> Greg,
>
> Just wanted to give you a heads up on this series and the ones I have
> posted. The series are:
>
> >From Ian, [PATCH 00/48] staging: comedi: avoid using comedi_board()
> >From me, [PATCH 00/30] staging: comedi: adl_pci9118: continue cleanup
> >From me, [PATCH 00/34] staging: comedi: cleanup async cmd->stop_{src,arg} usage
>
> There are a couple conflicts between the series from Ian and my two.
> If you drop these two from Ian's series:
>
> 06) staging: comedi: adl_pci9118: replace comedi_board() calls
> 10) staging: comedi: amplc_dio200_common: replace comedi_board() calls
>
> The rest will apply cleanly in the order above (assuming I didn't miss anything).
I applied all of the above, with the 2 patches from Ian going last and
git handling the merge issues.
> Also, Ian had a couple issues with patch 07/34 and 08/34 from the last
> series I posted. I already asked if you could drop those two. I needed I
> will repost the series.
I've dropped them. Hopefully I got it all right, it should all be
pushed out now, verifying this would be good :)
thanks,
greg k-h
next prev parent reply other threads:[~2014-09-11 21:37 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 10:26 [PATCH 00/48] staging: comedi: avoid using comedi_board() Ian Abbott
2014-09-09 10:26 ` [PATCH 01/48] staging: comedi: addi_common: replace comedi_board() calls Ian Abbott
2014-09-09 10:26 ` [PATCH 02/48] staging: comedi: addi_eeprom: " Ian Abbott
2014-09-09 10:26 ` [PATCH 03/48] staging: comedi: addi_apci_1516: " Ian Abbott
2014-09-09 10:26 ` [PATCH 04/48] staging: comedi: addi_apci_3120: " Ian Abbott
2014-09-09 10:26 ` [PATCH 05/48] staging: comedi: addi_apci_3xxx: " Ian Abbott
2014-09-09 10:26 ` [PATCH 06/48] staging: comedi: adl_pci9118: " Ian Abbott
2014-09-09 10:26 ` [PATCH 07/48] staging: comedi: adv_pci1710: " Ian Abbott
2014-09-09 10:26 ` [PATCH 08/48] staging: comedi: adv_pci_dio: " Ian Abbott
2014-09-09 10:26 ` [PATCH 09/48] staging: comedi: aio_aio12_8: " Ian Abbott
2014-09-09 10:26 ` [PATCH 10/48] staging: comedi: amplc_dio200_common: " Ian Abbott
2014-09-09 10:26 ` [PATCH 11/48] staging: comedi: amplc_pc236_common: " Ian Abbott
2014-09-09 10:26 ` [PATCH 12/48] staging: comedi: amplc_pci224: " Ian Abbott
2014-09-09 10:26 ` [PATCH 13/48] staging: comedi: amplc_pci230: " Ian Abbott
2014-09-09 10:26 ` [PATCH 14/48] staging: comedi: cb_pcidas64: " Ian Abbott
2014-09-09 10:26 ` [PATCH 15/48] staging: comedi: cb_pcidas: " Ian Abbott
2014-09-09 10:26 ` [PATCH 16/48] staging: comedi: das08: " Ian Abbott
2014-09-09 10:26 ` [PATCH 17/48] staging: comedi: das08_isa: " Ian Abbott
2014-09-09 10:26 ` [PATCH 18/48] staging: comedi: das16: " Ian Abbott
2014-09-09 10:26 ` [PATCH 19/48] staging: comedi: das1800: " Ian Abbott
2014-09-09 10:26 ` [PATCH 20/48] staging: comedi: das6402: " Ian Abbott
2014-09-09 10:26 ` [PATCH 21/48] staging: comedi: das800: " Ian Abbott
2014-09-09 10:26 ` [PATCH 22/48] staging: comedi: dt2801: " Ian Abbott
2014-09-09 10:26 ` [PATCH 23/48] staging: comedi: dt2811: " Ian Abbott
2014-09-09 10:26 ` [PATCH 24/48] staging: comedi: dt282x: " Ian Abbott
2014-09-09 10:26 ` [PATCH 25/48] staging: comedi: dt3000: " Ian Abbott
2014-09-09 10:26 ` [PATCH 26/48] staging: comedi: me4000: " Ian Abbott
2014-09-09 10:26 ` [PATCH 27/48] staging: comedi: ni_65xx: " Ian Abbott
2014-09-09 10:26 ` [PATCH 28/48] staging: comedi: ni_660x: " Ian Abbott
2014-09-09 10:26 ` [PATCH 29/48] staging: comedi: ni_at_a2150: " Ian Abbott
2014-09-09 10:26 ` [PATCH 30/48] staging: comedi: ni_at_ao: " Ian Abbott
2014-09-09 10:26 ` [PATCH 31/48] staging: comedi: ni_atmio16d: " Ian Abbott
2014-09-09 10:26 ` [PATCH 32/48] staging: comedi: ni_atmio: " Ian Abbott
2014-09-09 10:26 ` [PATCH 33/48] staging: comedi: ni_labpc_common: " Ian Abbott
2014-09-09 10:26 ` [PATCH 34/48] staging: comedi: ni_labpc_isadma: " Ian Abbott
2014-09-09 10:26 ` [PATCH 35/48] staging: comedi: ni_mio_common: " Ian Abbott
2014-09-09 10:26 ` [PATCH 36/48] staging: comedi: ni_pcimio: " Ian Abbott
2014-09-09 10:26 ` [PATCH 37/48] staging: comedi: pcl711: " Ian Abbott
2014-09-09 10:26 ` [PATCH 38/48] staging: comedi: pcl724: " Ian Abbott
2014-09-09 10:26 ` [PATCH 39/48] staging: comedi: pcl726: " Ian Abbott
2014-09-09 10:26 ` [PATCH 40/48] staging: comedi: pcl730: " Ian Abbott
2014-09-09 10:26 ` [PATCH 41/48] staging: comedi: pcl812: " Ian Abbott
2014-09-09 10:26 ` [PATCH 42/48] staging: comedi: pcl816: " Ian Abbott
2014-09-09 10:26 ` [PATCH 43/48] staging: comedi: pcl818: " Ian Abbott
2014-09-09 10:26 ` [PATCH 44/48] staging: comedi: pcmad: " Ian Abbott
2014-09-09 10:26 ` [PATCH 45/48] staging: comedi: pcmuio: " Ian Abbott
2014-09-09 10:26 ` [PATCH 46/48] staging: comedi: rtd520: " Ian Abbott
2014-09-09 10:26 ` [PATCH 47/48] staging: comedi: rti800: " Ian Abbott
2014-09-09 10:26 ` [PATCH 48/48] staging: comedi: vmk80xx: " Ian Abbott
2014-09-09 16:28 ` [PATCH 00/48] staging: comedi: avoid using comedi_board() Hartley Sweeten
2014-09-11 17:57 ` Hartley Sweeten
2014-09-11 21:37 ` Greg Kroah-Hartman [this message]
2014-09-11 22:00 ` Hartley Sweeten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140911213741.GA4542@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=HartleyS@visionengravers.com \
--cc=abbotti@mev.co.uk \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.