From: Greg KH <gregkh@linuxfoundation.org>
To: Kees Cook <keescook@chromium.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
"John W. Linville" <linville@tuxdriver.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: repeated bugs in new rtl wifi drivers
Date: Thu, 11 Sep 2014 15:37:44 -0700 [thread overview]
Message-ID: <20140911223744.GA21531@kroah.com> (raw)
In-Reply-To: <CAGXu5j+kh3TTR8yiyH35mXUo91g5a-ULS6w2CvKzGmQ4UuL-aA@mail.gmail.com>
On Thu, Sep 11, 2014 at 03:27:39PM -0700, Kees Cook wrote:
> Hi,
>
> I keep fixing this same bug that keeps showing up in the rtl wifi
> drivers. CL_PRINTF keeps getting redefined (incorrectly) instead of
> using a correctly fixed global. Is there a way to stop this from
> happening again?
>
> Here are the past three (identical) fixes I've landed:
> a3355a62673e2c4bd8617d2f07c8edee92a89b8d
> 037526f1ae7eeff5cf27ad790ebfe30303eeebe8
> 6437f51ec36af8ef1e3e2659439b35c37e5498e2
>
> And the buildbot report below seems to show there are more to be made. :)
Until we figure out a way to keep having the whole rtl wifi driver as a
duplicate of the previous driver before we cleaned it up, I don't know
of a way to do this :(
Larry, I know you keep talking to these developers, any chance anything
is ever going to get better? Anyone I can talk to? Even in person, I
go to Taiwan fairly often...
thanks,
greg k-h
next prev parent reply other threads:[~2014-09-11 22:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-11 22:27 repeated bugs in new rtl wifi drivers Kees Cook
2014-09-11 22:37 ` Greg KH [this message]
2014-09-11 23:38 ` Larry Finger
2014-09-11 23:50 ` Kees Cook
2014-09-12 0:31 ` Larry Finger
2014-09-12 10:49 ` Masanari Iida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140911223744.GA21531@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Larry.Finger@lwfinger.net \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.