Re: [PATCH v2 16/18] OvmfPkg/XenPvBlkDxe: Xen PV Block device, initial skeleton

[Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>]

> +
> +//
> +// Driver Version
> +//
> +#define XEN_PV_BLK_DXE_VERSION  0x00000000

This is 0, while ..
> +
> +
> +//
> +// Protocol instances
> +//
> +extern EFI_DRIVER_BINDING_PROTOCOL  gXenPvBlkDxeDriverBinding;
> +extern EFI_COMPONENT_NAME2_PROTOCOL  gXenPvBlkDxeComponentName2;
> +extern EFI_COMPONENT_NAME_PROTOCOL  gXenPvBlkDxeComponentName;
> +
> +
> +//
> +// Include files with function prototypes
> +//
> +#include "DriverBinding.h"
> +#include "ComponentName.h"
> +
> +
> +#endif
> diff --git a/OvmfPkg/XenPvBlkDxe/XenPvBlkDxe.inf b/OvmfPkg/XenPvBlkDxe/XenPvBlkDxe.inf
> new file mode 100644
> index 0000000..aaa809f
> --- /dev/null
> +++ b/OvmfPkg/XenPvBlkDxe/XenPvBlkDxe.inf
> @@ -0,0 +1,76 @@
> +
> +## @file
> +#  TODO: Brief Description of UEFI Driver XenPvBlkDxe
> +#
> +#  Copyright (C) 2014, Citrix Ltd.
> +#
> +#  Redistribution and use in source and binary forms, with or without
> +#  modification, are permitted provided that the following conditions
> +#  are met:
> +#
> +#  * Redistributions of source code must retain the above copyright
> +#    notice, this list of conditions and the following disclaimer.
> +#  * Redistributions in binary form must reproduce the above copyright
> +#    notice, this list of conditions and the following disclaimer in
> +#    the documentation and/or other materials provided with the
> +#    distribution.
> +#
> +#  THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
> +#  "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
> +#  LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
> +#  FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
> +#  COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
> +#  INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
> +#  BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
> +#  LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
> +#  CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
> +#  LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
> +#  ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> +#  POSSIBILITY OF SUCH DAMAGE.
> +#
> +##
> +
> +[Defines]
> +  INF_VERSION               = 0x00010005
> +  BASE_NAME                 = XenPvBlkDxe
> +  FILE_GUID                 = 8c2487ea-9af3-11e3-b966-b8ac6f7d65e6
> +  MODULE_TYPE               = UEFI_DRIVER
> +
> +  VERSION_STRING            = 0.1

This is 0.1?

Should it have the same version number?

> +  ENTRY_POINT               = XenPvBlkDxeDriverEntryPoint
> +  UNLOAD_IMAGE              = XenPvBlkDxeUnload
> +
> +
> +[Packages]
> +  MdePkg/MdePkg.dec
> +  OvmfPkg/OvmfPkg.dec
> +
> +[Sources]
> +  XenPvBlkDxe.h
> +  XenPvBlkDxe.c
> +  ComponentName.c
> +  ComponentName.h
> +
> +
> +[LibraryClasses]
> +  UefiDriverEntryPoint
> +  UefiBootServicesTableLib
> +  MemoryAllocationLib
> +  BaseMemoryLib
> +  BaseLib
> +  UefiLib
> +  DevicePathLib
> +  DebugLib
> +
> +
> +[Protocols]
> +  gEfiDriverBindingProtocolGuid
> +  gEfiBlockIoProtocolGuid
> +  gEfiComponentName2ProtocolGuid
> +  gEfiComponentNameProtocolGuid
> +  gXenBusProtocolGuid
> +  gEfiDevicePathProtocolGuid                    ## TO_START
> +
> +
> +[Guids]
> +
> -- 
> Anthony PERARD
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel