All of lore.kernel.org
 help / color / mirror / Atom feed
From: Minchan Kim <minchan@kernel.org>
To: Wang Sheng-Hui <shhuiw@gmail.com>
Cc: ngupta@vflare.org, linux-mm@kvack.org,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] mm: correct comment for fullness group computation in zsmalloc.c
Date: Mon, 15 Sep 2014 15:51:52 +0900	[thread overview]
Message-ID: <20140915065152.GL2160@bbox> (raw)
In-Reply-To: <1410681467-13891-1-git-send-email-shhuiw@gmail.com>

On Sun, Sep 14, 2014 at 03:57:47PM +0800, Wang Sheng-Hui wrote:
> The letter 'f' in "n <= N/f" stands for fullness_threshold_frac, not
> 1/fullness_threshold_frac.
> 
> Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>
Acked-by: Minchan Kim <minchan@kernel.org>

Thanks.

> ---
>  mm/zsmalloc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
> index 94f38fa..287a8dc 100644
> --- a/mm/zsmalloc.c
> +++ b/mm/zsmalloc.c
> @@ -175,7 +175,7 @@ enum fullness_group {
>   *	n <= N / f, where
>   * n = number of allocated objects
>   * N = total number of objects zspage can store
> - * f = 1/fullness_threshold_frac
> + * f = fullness_threshold_frac
>   *
>   * Similarly, we assign zspage to:
>   *	ZS_ALMOST_FULL	when n > N / f
> -- 
> 1.8.3.2
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

-- 
Kind regards,
Minchan Kim

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

      reply	other threads:[~2014-09-15  6:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-14  7:57 [PATCH] mm: correct comment for fullness group computation in zsmalloc.c Wang Sheng-Hui
2014-09-15  6:51 ` Minchan Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140915065152.GL2160@bbox \
    --to=minchan@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-mm@kvack.org \
    --cc=ngupta@vflare.org \
    --cc=shhuiw@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.