From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ezequiel Garcia Subject: Re: [PATCH/RESEND 0/8] tilcdc-panel: Backlight and GPIO devicetree support Date: Mon, 15 Sep 2014 08:50:07 +0100 Message-ID: <20140915075007.GA1152@arch.hh.imgtec.org> References: <1409662282-7945-1-git-send-email-ezequiel@vanguardiasur.com.ar> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f51.google.com (mail-wg0-f51.google.com [74.125.82.51]) by gabe.freedesktop.org (Postfix) with ESMTP id 732D86E2D4 for ; Mon, 15 Sep 2014 00:51:30 -0700 (PDT) Received: by mail-wg0-f51.google.com with SMTP id k14so3465760wgh.10 for ; Mon, 15 Sep 2014 00:51:24 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dave Airlie Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org Dave, On 03 Sep 08:08 AM, Johannes Pointner wrote: > 2014-09-02 14:51 GMT+02:00 Ezequiel Garcia : > > Dave, > > > > I'm resending this, hoping it can be pushed for v3.18. The patchset was > > ready for v3.17, but it got no maintainer feedback or review. Maybe it fell > > through some crack? > > > > Just for reference, here goes the details about this series and why it's > > needed: > > > > This patchset adds the required changes to support an optional backlight > > and GPIO for the tilcdc panel driver. > > > > There was some code to support a backlight, but it was broken and undocumented. > > I've followed the nice implementation in panel-simple and added a similar > > one here. > > > > The enable GPIO is required to turn on and off devices with such capability. > > Also here, I've followed panel-simple which looks correct. > > > > In addition to this there are very minor cosmetic cleanups and a larger > > fix for the error path in tilcdc's DRM driver .load error path. > > > > I tested the series with 3.16.1 (with additonal patches from Guido and > Sachin) and with 3.17-rc3 with a custom AM335x board and it worked for > me without an issue. I tried it with and without the backlight > addition in the dts file. > > For the series: > Tested-by: Johannes Pointner > Any feedback for this series? If at all possible, it'd be great to not miss the merge this time. -- Ezequiel Garcia, VanguardiaSur www.vanguardiasur.com.ar