From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH V8 for-4.5 4/4] xen: Handle resumed instruction based on previous mem_event reply Date: Mon, 15 Sep 2014 08:23:59 -0400 Message-ID: <20140915122359.GA7070@laptop.dumpdata.com> References: <1410762248-23825-1-git-send-email-rcojocaru@bitdefender.com> <1410762248-23825-5-git-send-email-rcojocaru@bitdefender.com> <5416DC120200007800034EA8@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XTVSS-0007eZ-Ej for xen-devel@lists.xenproject.org; Mon, 15 Sep 2014 12:32:40 +0000 Content-Disposition: inline In-Reply-To: <5416DC120200007800034EA8@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: kevin.tian@intel.com, keir@xen.org, ian.campbell@citrix.com, Razvan Cojocaru , stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, eddie.dong@intel.com, tim@xen.org, jun.nakajima@intel.com, xen-devel@lists.xenproject.org, ian.jackson@eu.citrix.com List-Id: xen-devel@lists.xenproject.org > Purely from a technical perspective this patch (and hence now this > series) looks fine to me, with one nit: Woohoo! .. > While I think that most pre-existing types here are sufficiently > self-explaining, I don't think the new type is, and hence it > warrants a comment. Of course the final say on this will be with > Tim (being the maintainer). > > I also think that with the series having got reduced, there's no > longer a process problem, but I'd nevertheless like to point out two > things for you going forward (in the hope that this won't make you > drop your Xen efforts): With the larger pieces of code additions > you have pending on top of this series, we would really like to see > at least PoC in-tree users of any such addition, perhaps even going > as far as integrating them with osstest. This is (among other > aspects like helping understanding the purpose) so that the code > you add (and that's - at least initially - used only by you) won't > become stale sooner or later. Or worst, you get hit by a bus and some patches end up triggering regressions - but nobody noticies since we have no automatic way of detecting them - and the release comes out with regressions! > > The second aspect is that to help acceptance of the addition of > changes that are large and/or very special purpose it would be > beneficial if we would see previous smaller scale contributions by > the exact same people (e.g. bug fixes, code reviews). This is in > the spirit of, as is being said in the governance document, the > project being run as a meritocracy, not a democracy. I would like to thank everybody involved in the design/review and shaping the patches to get them in the hypervisor. It is pretty awesome seeing something getting posted, changed and shaped - and being ready for integration! The emphasize Jan's view - you have quite the skill sets in the code base - and it would be really great if it could be also used in reviewing other folks code in the areas you feel comfortable in - it would help on the load of patches that are streaming in. Thought I am sure that at this point you had been focusing on adapting the code to reviewer's feedback and hadn't had a chance to look at other emails. Looking forward to seeing more emails from you! > > And of course - as with any new functionality being added - it > always helps if from the very beginning you make clear why > existing functionality doesn't fit your needs. > > Jan > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel