From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Mon, 15 Sep 2014 19:25:24 +0200 Subject: [U-Boot] [PATCH 05/35] mmc: dw_mmc: cleanups In-Reply-To: <54170D2F.5040303@opensource.altera.com> References: <1410779188-6880-1-git-send-email-marex@denx.de> <1410779188-6880-6-git-send-email-marex@denx.de> <54170D2F.5040303@opensource.altera.com> Message-ID: <201409151925.24719.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Monday, September 15, 2014 at 06:00:47 PM, Dinh Nguyen wrote: > On 09/15/2014 06:05 AM, Marek Vasut wrote: > > From: Pavel Machek > > > > The dw_mmc driver was responding to errors with debug(). Change that > > to prinf()/puts() respectively so that any errors are immediately > > obvious. Also adjust english in comments. [...] > > @@ -290,7 +292,7 @@ static void dwmci_set_ios(struct mmc *mmc) > > > > struct dwmci_host *host = (struct dwmci_host *)mmc->priv; > > u32 ctype, regs; > > > > - debug("Buswidth = %d, clock: %d\n",mmc->bus_width, mmc->clock); > > + debug("Buswidth = %d, clock: %d\n", mmc->bus_width, mmc->clock); > > Did you intend to use printf here also? Or just fix up the spacing > around mmc->bus_width? This cannot be a printf(), since you would get an output upon every call of .set_ios(). This would generate a wall of text. So this is formatting fix. Best regards, Marek Vasut