From: Dan Carpenter <dan.carpenter@oracle.com>
To: jaegeuk@kernel.org
Cc: linux-f2fs-devel@lists.sourceforge.net
Subject: Re: f2fs: use meta_inode cache to improve roll-forward speed
Date: Mon, 15 Sep 2014 22:37:58 +0300 [thread overview]
Message-ID: <20140915193758.GA19290@mwanda> (raw)
Hello Jaegeuk Kim,
The patch 17ef549eef6e: "f2fs: use meta_inode cache to improve
roll-forward speed" from Sep 11, 2014, leads to the following static
checker warning:
fs/f2fs/recovery.c:180 find_fsync_dnodes()
warn: 'page' isn't an ERR_PTR
fs/f2fs/recovery.c
178
179 page = get_meta_page(sbi, blkaddr);
180 if (IS_ERR(page))
^^^^^^^^^^^
Is get_meta_page() supposed to return an ERR_PTR()? The comment says
"We guarantee no failure on the returned page."
181 return PTR_ERR(page);
182
Also:
fs/f2fs/recovery.c:446 recover_data() warn: 'page' isn't an ERR_PTR
regards,
dan carpenter
------------------------------------------------------------------------------
Want excitement?
Manually upgrade your production database.
When you want reliability, choose Perforce
Perforce version control. Predictably reliable.
http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk
next reply other threads:[~2014-09-15 19:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-15 19:37 Dan Carpenter [this message]
2014-09-18 5:48 ` f2fs: use meta_inode cache to improve roll-forward speed Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140915193758.GA19290@mwanda \
--to=dan.carpenter@oracle.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.