From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Michael Wright <michaelwr@android.com>
Cc: David Herrmann <dh.herrmann@gmail.com>,
"open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
Michael Wright <michaelwr@google.com>,
Jiri Kosina <jkosina@suse.cz>
Subject: Re: [PATCH] HID: add new gamepad LED constants
Date: Mon, 15 Sep 2014 17:54:03 -0700 [thread overview]
Message-ID: <20140916005403.GA21751@core.coreip.homeip.net> (raw)
In-Reply-To: <CAON4U=NqrMK=baJBLGWY=-+jwDdAE==LRDHU35Rya6GhdnrsQA@mail.gmail.com>
On Mon, Sep 15, 2014 at 04:41:42PM -0700, Michael Wright wrote:
> > LEDs should be controlled via LED subsystem. The fact that they happen
> > to be located on a given device does not mean they belong to input
> > subsystem. The same as LEds on network card are not part of network stack,
> > etc.
>
> I think the fundamental difference for me is that the primary input
> standard does
> have a specification for how to interact with LEDs,
... That predates LED subsystem. When we saw that it is not flexible enough LED
subsystem was created. Input, for better or worse, has "sound" support as well,
but I do not think anyone would want to to enhance it to support 7.1 surround
output ;)
> and right now the LED
> subsystem has no knowledge of HID whatsoever.
Then that is something that needs to be changed.
>
> Even if I did add the plumbing for HID over into the LED subsystem, is there an
> easy way to correlate input devices and their LEDs from userspace?
What does it mean "their led"? The led that happens to share the same physical
package?
Thanks.
--
Dmitry
next prev parent reply other threads:[~2014-09-16 0:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-15 3:13 [PATCH] HID: add new gamepad LED constants Michael Wright
2014-09-15 5:07 ` David Herrmann
2014-09-15 18:03 ` Michael Wright
2014-09-15 21:57 ` Dmitry Torokhov
2014-09-15 22:15 ` David Herrmann
2014-09-15 22:58 ` Dmitry Torokhov
2014-09-15 23:41 ` Michael Wright
2014-09-16 0:54 ` Dmitry Torokhov [this message]
2014-09-16 1:02 ` Michael Wright
2014-09-16 2:00 ` simon
2014-09-16 4:06 ` Michael Wright
2014-09-17 1:44 ` Pierre-Loup A. Griffais
2014-09-17 1:56 ` Michael Wright
2014-09-22 21:36 ` Michael Wright
2014-09-23 16:40 ` Dmitry Torokhov
2014-09-16 10:00 ` David Herrmann
2014-09-23 16:37 ` Dmitry Torokhov
2014-09-25 10:26 ` David Herrmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140916005403.GA21751@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=dh.herrmann@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=michaelwr@android.com \
--cc=michaelwr@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.